Ensure that the Deprecated::$message property is treated as readonly by Deprecated::__construct()

Author: TimWolla

Zend/tests/attributes/deprecated_005.phpt

@@ -0,0 +1,15 @@
+--TEST--
+#[Deprecated]’s $message property is readonly.
+--FILE--
+<?php
+
+$d = new Deprecated("foo");
+$d->__construct("bar");
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Cannot modify readonly property Deprecated::$message in %s:%d
+Stack trace:
+#0 %s(%d): Deprecated->__construct('bar')
+#1 {main}
+  thrown in %s on line %d

Zend/zend_attributes.c

@@ -172,17 +172,20 @@ ZEND_METHOD(Override, __construct)
 ZEND_METHOD(Deprecated, __construct)
 {
 	zend_string *message = NULL;
+	zval value;
+
+	ZVAL_NULL(&value);
 
 	ZEND_PARSE_PARAMETERS_START(0, 1)
 		Z_PARAM_OPTIONAL
 		Z_PARAM_STR_OR_NULL(message)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (message) {
-		ZVAL_STR(OBJ_PROP_NUM(Z_OBJ_P(ZEND_THIS), 0), message);
-	} else {
-		ZVAL_NULL(OBJ_PROP_NUM(Z_OBJ_P(ZEND_THIS), 0));
+		ZVAL_STR(&value, message);
 	}
+
+	zend_update_property_ex(zend_ce_deprecated_attribute, Z_OBJ_P(ZEND_THIS), ZSTR_KNOWN(ZEND_STR_MESSAGE), &value);
 }
 
 static zend_attribute *get_attribute(HashTable *attributes, zend_string *lcname, uint32_t offset)