rm always empty ignored_by_ext global var

Author: mvorisek

run-tests.php

@@ -154,7 +154,7 @@ function main(): void
     global $DETAILED, $PHP_FAILED_TESTS, $SHOW_ONLY_GROUPS, $argc, $argv, $cfg,
            $cfgfiles, $cfgtypes, $conf_passed, $end_time, $environment,
            $exts_to_test, $failed_tests_file,
-           $ignored_by_ext, $ini_overwrites, $is_switch, $colorize,
+           $ini_overwrites, $is_switch, $colorize,
            $log_format, $matches, $no_clean, $no_file_cache,
            $optionals, $pass_option_n, $pass_options,
            $pattern_match, $php, $php_cgi, $phpdbg, $preload, $redir_tests,
@@ -735,7 +735,6 @@ function main(): void
     } else {
         // Compile a list of all test files (*.phpt).
         $test_files = [];
-        $ignored_by_ext = [];
         sort($exts_to_test);
         $test_dirs = [];
         $optionals = ['Zend', 'tests', 'ext', 'sapi'];
@@ -752,11 +751,11 @@ function main(): void
         }
 
         foreach ($test_dirs as $dir) {
-            find_files(TEST_PHP_SRCDIR . "/{$dir}", $dir == 'ext');
+            find_files(TEST_PHP_SRCDIR . "/{$dir}");
         }
 
         foreach ($user_tests as $dir) {
-            find_files($dir, $dir == 'ext');
+            find_files($dir);
         }
 
         $test_files = array_unique($test_files);
@@ -1045,9 +1044,9 @@ function get_binary(string $php, string $sapi, string $sapi_path): ?string
     return null;
 }
 
-function find_files(string $dir, bool $is_ext_dir = false, bool $ignore = false): void
+function find_files(string $dir): void
 {
-    global $test_files, $ignored_by_ext;
+    global $test_files;
 
     $o = opendir($dir) or error("cannot open directory: $dir");
 
@@ -1057,7 +1056,7 @@ function find_files(string $dir, bool $is_ext_dir = false, bool $ignore = false)
         }
 
         if (is_dir("{$dir}/{$name}")) {
-            find_files("{$dir}/{$name}", false, $ignore);
+            find_files("{$dir}/{$name}");
         }
 
         // Cleanup any left-over tmp files from last run.
@@ -1071,11 +1070,7 @@ function find_files(string $dir, bool $is_ext_dir = false, bool $ignore = false)
         // many platforms)
         if (substr($name, -5) == '.phpt' && substr($name, 0, 1) !== '.') {
             $testfile = realpath("{$dir}/{$name}");
-            if ($ignore) {
-                $ignored_by_ext[] = $testfile;
-            } else {
-                $test_files[] = $testfile;
-            }
+            $test_files[] = $testfile;
         }
     }
 
@@ -3029,10 +3024,9 @@ function settings2params(array $ini_settings): string
 
 function compute_summary(): void
 {
-    global $n_total, $test_results, $ignored_by_ext, $sum_results, $percent_results;
+    global $n_total, $test_results, $sum_results, $percent_results;
 
     $n_total = count($test_results);
-    $n_total += count($ignored_by_ext);
     $sum_results = [
         'PASSED' => 0,
         'WARNED' => 0,
@@ -3048,7 +3042,6 @@ function compute_summary(): void
         $sum_results[$v]++;
     }
 
-    $sum_results['SKIPPED'] += count($ignored_by_ext);
     $percent_results = [];
 
     foreach ($sum_results as $v => $n) {