Fixed assertion when check "instanceof" on unlinked class

Author: dstogov

Zend/Optimizer/zend_inference.c

@@ -3630,6 +3630,17 @@ static zend_class_entry *join_class_entries(
 	return ce1;
 }
 
+static bool safe_instanceof(zend_class_entry *ce1, zend_class_entry *ce2) {
+	if (ce1 == ce2) {
+		return 1;
+	}
+	if (!(ce1->ce_flags & ZEND_ACC_LINKED)) {
+		/* This case could be generalized, similarly to unlinked_instanceof */
+		return 0;
+	}
+	return instanceof_function(ce1, ce2);
+}
+
 static zend_result zend_infer_types_ex(const zend_op_array *op_array, const zend_script *script, zend_ssa *ssa, zend_bitset worklist, zend_long optimization_level)
 {
 	zend_basic_block *blocks = ssa->cfg.blocks;
@@ -3661,7 +3672,7 @@ static zend_result zend_infer_types_ex(const zend_op_array *op_array, const zend
 						if (!ce) {
 							ce = constraint->ce;
 							is_instanceof = 1;
-						} else if (is_instanceof && instanceof_function(constraint->ce, ce)) {
+						} else if (is_instanceof && safe_instanceof(constraint->ce, ce)) {
 							ce = constraint->ce;
 						} else {
 							/* Ignore the constraint (either ce instanceof constraint->ce or

ext/opcache/tests/opt/inference_003.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Type inference 003: instanceof with unlinked class
+--INI--
+opcache.enable=1
+opcache.enable_cli=1
+opcache.optimization_level=-1
+--FILE--
+<?php
+class C implements I {
+    public static function wrap(\Throwable $e): C {
+        return $e instanceof C ? $e : new C($e->getMessage());
+    }
+}
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Interface "I" not found in %sinference_003.php:2
+Stack trace:
+#0 {main}
+  thrown in %sinference_003.php on line 2
+