random: Add explicitly named seed64() helper for xoshiro256**

TimWolla · TimWolla · commit 304c9c3db19e · 2024-01-31T08:49:17.000+01:00
diff --git a/ext/random/engine_xoshiro256starstar.c b/ext/random/engine_xoshiro256starstar.c
@@ -89,7 +89,7 @@ static inline void seed256(php_random_status_state_xoshiro256starstar *s, uint64
 	s->state[3] = s3;
 }
 
-static void seed(php_random_status *status, uint64_t seed)
+static inline void seed64(php_random_status_state_xoshiro256starstar *state, uint64_t seed)
 {
 	uint64_t s[4];
 
@@ -98,7 +98,12 @@ static void seed(php_random_status *status, uint64_t seed)
 	s[2] = splitmix64(&seed);
 	s[3] = splitmix64(&seed);
 
-	seed256(status->state, s[0], s[1], s[2], s[3]);
+	seed256(state, s[0], s[1], s[2], s[3]);
+}
+
+static void seed(php_random_status *status, uint64_t seed)
+{
+	seed64(status->state, seed);
 }
 
 static php_random_result generate(php_random_status *status)

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ static inline void seed256(php_random_status_state_xoshiro256starstar *s, uint64`
`89`	`89`	`s->state[3] = s3;`
`90`	`90`	`}`
`91`	`91`
`92`		`-static void seed(php_random_status *status, uint64_t seed)`
	`92`	`+static inline void seed64(php_random_status_state_xoshiro256starstar *state, uint64_t seed)`
`93`	`93`	`{`
`94`	`94`	`uint64_t s[4];`
`95`	`95`
`@@ -98,7 +98,12 @@ static void seed(php_random_status *status, uint64_t seed)`
`98`	`98`	`s[2] = splitmix64(&seed);`
`99`	`99`	`s[3] = splitmix64(&seed);`
`100`	`100`
`101`		`- seed256(status->state, s[0], s[1], s[2], s[3]);`
	`101`	`+ seed256(state, s[0], s[1], s[2], s[3]);`
	`102`	`+}`
	`103`	`+`
	`104`	`+static void seed(php_random_status *status, uint64_t seed)`
	`105`	`+{`
	`106`	`+ seed64(status->state, seed);`
`102`	`107`	`}`
`103`	`108`
`104`	`109`	`static php_random_result generate(php_random_status *status)`