Skip to content

Commit 310b95d

Browse files
committed
Merge branch 'PHP-7.1' into PHP-7.2
* PHP-7.1: Add support for getting SKIP_TAGSTART and SKIP_WHITE options
2 parents f1d7e3c + b331242 commit 310b95d

File tree

3 files changed

+36
-0
lines changed

3 files changed

+36
-0
lines changed

NEWS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ PHP NEWS
4646

4747
- XML:
4848
. Fixed bug #30875 (xml_parse_into_struct() does not resolve entities). (cmb)
49+
. Add support for getting SKIP_TAGSTART and SKIP_WHITE options. (cmb)
4950

5051
11 Oct 2018, PHP 7.2.11
5152

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
--TEST--
2+
xml_parser_get_option() with XML_OPTION_SKIP_TAGSTART and XML_OPTION_SKIP_WHITE
3+
--SKIPIF--
4+
<?php
5+
if (!extension_loaded('xml')) die('skip xml extension not available');
6+
?>
7+
--FILE--
8+
<?php
9+
$parser = xml_parser_create();
10+
echo "defaults:\n";
11+
var_dump(xml_parser_get_option($parser, XML_OPTION_SKIP_TAGSTART));
12+
var_dump(xml_parser_get_option($parser, XML_OPTION_SKIP_WHITE));
13+
echo "setting:\n";
14+
var_dump(xml_parser_set_option($parser, XML_OPTION_SKIP_TAGSTART, 7));
15+
var_dump(xml_parser_set_option($parser, XML_OPTION_SKIP_WHITE, 1));
16+
echo "getting:\n";
17+
var_dump(xml_parser_get_option($parser, XML_OPTION_SKIP_TAGSTART));
18+
var_dump(xml_parser_get_option($parser, XML_OPTION_SKIP_WHITE));
19+
?>
20+
--EXPECT--
21+
defaults:
22+
int(0)
23+
int(0)
24+
setting:
25+
bool(true)
26+
bool(true)
27+
getting:
28+
int(7)
29+
int(1)

ext/xml/xml.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1643,6 +1643,12 @@ PHP_FUNCTION(xml_parser_get_option)
16431643
case PHP_XML_OPTION_CASE_FOLDING:
16441644
RETURN_LONG(parser->case_folding);
16451645
break;
1646+
case PHP_XML_OPTION_SKIP_TAGSTART:
1647+
RETURN_LONG(parser->toffset);
1648+
break;
1649+
case PHP_XML_OPTION_SKIP_WHITE:
1650+
RETURN_LONG(parser->skipwhite);
1651+
break;
16461652
case PHP_XML_OPTION_TARGET_ENCODING:
16471653
RETURN_STRING((char *)parser->target_encoding);
16481654
break;

0 commit comments

Comments
 (0)