clone is fast, cache not needed

Author: mvorisek

.appveyor.yml

@@ -11,9 +11,6 @@ skip_commits:
     - UPGRADING
     - UPGRADING.INTERNALS
 
-cache:
-        - c:\build-cache
-
 environment:
         PHP_BUILD_CACHE_BASE_DIR: c:\build-cache
         PHP_BUILD_OBJ_DIR: c:\obj

.github/scripts/windows/build.bat

@@ -9,24 +9,11 @@ set SDK_REMOTE=https://github.com/php/php-sdk-binary-tools.git
 set SDK_BRANCH=%PHP_BUILD_SDK_BRANCH%
 set SDK_RUNNER=%PHP_BUILD_CACHE_SDK_DIR%\phpsdk-%PHP_BUILD_CRT%-%PLATFORM%.bat
 
-if not exist "%PHP_BUILD_CACHE_BASE_DIR%" (
-	echo Creating %PHP_BUILD_CACHE_BASE_DIR%
-	mkdir "%PHP_BUILD_CACHE_BASE_DIR%"
-)
-
-if not exist "%PHP_BUILD_OBJ_DIR%" (
-	echo Creating %PHP_BUILD_OBJ_DIR%
-	mkdir "%PHP_BUILD_OBJ_DIR%"
-)
+mkdir "%PHP_BUILD_CACHE_BASE_DIR%"
+mkdir "%PHP_BUILD_OBJ_DIR%"
 
-if not exist "%SDK_RUNNER%" (
-	if exist "%PHP_BUILD_CACHE_SDK_DIR%" rmdir /s /q "%PHP_BUILD_CACHE_SDK_DIR%"
-)
-
-if not exist "%PHP_BUILD_CACHE_SDK_DIR%" (
-	echo Cloning remote SDK repository
-	git clone -q --branch %SDK_BRANCH% %SDK_REMOTE% --depth 1 "%PHP_BUILD_CACHE_SDK_DIR%" 2>&1
-)
+echo Cloning remote SDK repository
+git clone -q --branch %SDK_BRANCH% %SDK_REMOTE% --depth 1 "%PHP_BUILD_CACHE_SDK_DIR%" 2>&1
 
 for /f "tokens=*" %%a in ('type %PHP_BUILD_CACHE_SDK_DIR%\VERSION') do set GOT_SDK_VER=%%a
 echo Got SDK version %GOT_SDK_VER%
@@ -39,4 +26,3 @@ if NOT "%GOT_SDK_VER%" == "%PHP_BUILD_SDK_BRANCH:~8%" (
 )
 
 cmd /c %SDK_RUNNER% -t .github\scripts\windows\build_task.bat
-if %errorlevel% neq 0 exit /b 3

.github/scripts/windows/build_task.bat

@@ -78,4 +78,3 @@ cmd /c configure.bat ^
 if %errorlevel% neq 0 exit /b 3
 
 nmake /NOLOGO /S
-if %errorlevel% neq 0 exit /b 3

.github/scripts/windows/test.bat

@@ -8,4 +8,3 @@ if /i "%APPVEYOR%%GITHUB_ACTIONS%" neq "True" (
 set SDK_RUNNER=%PHP_BUILD_CACHE_SDK_DIR%\phpsdk-%PHP_BUILD_CRT%-%PLATFORM%.bat
 
 cmd /c %SDK_RUNNER% -t %APPVEYOR_BUILD_FOLDER%\.github\scripts\windows\test_task.bat
-if %errorlevel% neq 0 exit /b 3