ext/intl: Small extension cleanup

Author: Girgias

ext/intl/collator/collator_class.c

@@ -77,15 +77,6 @@ void collator_register_Collator_symbols(int module_number)
 	Collator_handlers.offset = XtOffsetOf(Collator_object, zo);
 	Collator_handlers.clone_obj = NULL;
 	Collator_handlers.free_obj = Collator_objects_free;
-
-	/* Declare 'Collator' class properties. */
-	if( !Collator_ce_ptr )
-	{
-		zend_error( E_ERROR,
-			"Collator: attempt to create properties "
-			"on a non-registered class." );
-		return;
-	}
 }
 /* }}} */
 

ext/intl/resourcebundle/resourcebundle_iterator.c

@@ -148,13 +148,14 @@ static const zend_object_iterator_funcs resourcebundle_iterator_funcs = {
 /* {{{ resourcebundle_get_iterator */
 zend_object_iterator *resourcebundle_get_iterator( zend_class_entry *ce, zval *object, int byref )
 {
-	ResourceBundle_object   *rb = Z_INTL_RESOURCEBUNDLE_P(object );
-	ResourceBundle_iterator *iterator = emalloc( sizeof( ResourceBundle_iterator ) );
-
 	if (byref) {
-	     php_error( E_ERROR, "ResourceBundle does not support writable iterators" );
+		zend_throw_error(NULL, "An iterator cannot be used with foreach by reference");
+		return NULL;
 	}
 
+	ResourceBundle_object   *rb = Z_INTL_RESOURCEBUNDLE_P(object );
+	ResourceBundle_iterator *iterator = emalloc( sizeof( ResourceBundle_iterator ) );
+
 	zend_iterator_init(&iterator->intern);
 	Z_ADDREF_P(object);
 	ZVAL_OBJ(&iterator->intern.data, Z_OBJ_P(object));

ext/intl/tests/collator_get_error_code.phpt

@@ -36,9 +36,6 @@ function ut_main()
     return $res;
 }
 
-# Suppress warning messages.
-error_reporting( E_ERROR );
-
 include_once( 'ut_common.inc' );
 ut_run();
 ?>

ext/intl/tests/intl_get_error_code.phpt

@@ -8,9 +8,6 @@ intl
  * Check getting global error code.
  */
 
-// Suppress warning messages.
-error_reporting( E_ERROR );
-
 if( collator_get_locale(new Collator('en_US'), -1) !== false )
     echo "failed\n";
 else

ext/intl/tests/intl_get_error_message.phpt

@@ -8,9 +8,6 @@ intl
  * Check getting global error message.
  */
 
-// Suppress warning messages.
-error_reporting( E_ERROR );
-
 if( collator_get_locale(new Collator('en_US'), -1) !== false )
     echo "failed\n";
 else

ext/intl/tests/locale_compose_locale.phpt

@@ -101,8 +101,6 @@ function ut_main()
         'loc12' => $loc_parts_arr12
     );
 
-    error_reporting( E_ERROR );
-
     $cnt  = 0;
     $res_str = '';
     foreach($loc_parts_arr as $key => $value ){