Skip to content

Commit 39c9454

Browse files
kocsismatekocsismate
committed
Fix code review
1 parent 2a9298b commit 39c9454

7 files changed

+103
-105
lines changed

‎ext/date/php_date.c

Lines changed: 57 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -177,17 +177,13 @@ static HashTable *date_object_get_gc_timezone(zend_object *object, zval **table,
177177
static HashTable *date_object_get_debug_info_timezone(zend_object *object, int *is_temp);
178178
static void php_timezone_to_string(php_timezone_obj *tzobj, zval *zv);
179179

180-
static void create_date_period_datetime(timelib_time *datetime, zend_class_entry *ce, zval *zv);
181-
static void create_date_period_interval(timelib_rel_time *interval, zval *zv);
182-
static void initialize_date_period_properties(php_period_obj *period_obj);
183-
184180
static int date_interval_compare_objects(zval *o1, zval *o2);
185181
static zval *date_interval_read_property(zend_object *object, zend_string *member, int type, void **cache_slot, zval *rv);
186182
static zval *date_interval_write_property(zend_object *object, zend_string *member, zval *value, void **cache_slot);
187183
static zval *date_interval_get_property_ptr_ptr(zend_object *object, zend_string *member, int type, void **cache_slot);
188-
static zval *date_period_get_property_ptr_ptr(zend_object *object, zend_string *name, int type, void **cache_slot);
189184
static zval *date_period_read_property(zend_object *object, zend_string *name, int type, void **cache_slot, zval *rv);
190185
static zval *date_period_write_property(zend_object *object, zend_string *name, zval *value, void **cache_slot);
186+
static zval *date_period_get_property_ptr_ptr(zend_object *object, zend_string *name, int type, void **cache_slot);
191187

192188
static int date_object_compare_timezone(zval *tz1, zval *tz2);
193189

@@ -1432,6 +1428,62 @@ PHP_FUNCTION(getdate)
14321428

14331429
#define PHP_DATE_PERIOD_EXCLUDE_START_DATE 0x0001
14341430

1431+
static void create_date_period_datetime(timelib_time *datetime, zend_class_entry *ce, zval *zv)
1432+
{
1433+
if (datetime) {
1434+
php_date_obj *date_obj;
1435+
1436+
object_init_ex(zv, ce);
1437+
date_obj = Z_PHPDATE_P(zv);
1438+
date_obj->time = timelib_time_clone(datetime);
1439+
} else {
1440+
ZVAL_NULL(zv);
1441+
}
1442+
}
1443+
1444+
static void create_date_period_interval(timelib_rel_time *interval, zval *zv)
1445+
{
1446+
if (interval) {
1447+
php_interval_obj *interval_obj;
1448+
1449+
object_init_ex(zv, date_ce_interval);
1450+
interval_obj = Z_PHPINTERVAL_P(zv);
1451+
interval_obj->diff = timelib_rel_time_clone(interval);
1452+
interval_obj->initialized = 1;
1453+
} else {
1454+
ZVAL_NULL(zv);
1455+
}
1456+
}
1457+
1458+
static void initialize_date_period_properties(php_period_obj *period_obj)
1459+
{
1460+
zval start_zv, current_zv, end_zv, interval_zv;
1461+
1462+
if (UNEXPECTED(!period_obj->std.properties)) {
1463+
rebuild_object_properties(&period_obj->std);
1464+
}
1465+
1466+
create_date_period_datetime(period_obj->start, period_obj->start_ce, &start_zv);
1467+
zend_update_property(date_ce_period, &period_obj->std, "start", sizeof("start") - 1, &start_zv);
1468+
zval_ptr_dtor(&start_zv);
1469+
1470+
create_date_period_datetime(period_obj->current, period_obj->start_ce, &current_zv);
1471+
zend_string *property_name = zend_string_init("current", sizeof("current") - 1, 0);
1472+
zend_std_write_property(&period_obj->std, property_name, &current_zv, NULL);
1473+
zval_ptr_dtor(&current_zv);
1474+
zend_string_release(property_name);
1475+
1476+
create_date_period_datetime(period_obj->end, period_obj->start_ce, &end_zv);
1477+
zend_update_property(date_ce_period, &period_obj->std, "end", sizeof("end") - 1, &end_zv);
1478+
zval_ptr_dtor(&end_zv);
1479+
1480+
create_date_period_interval(period_obj->interval, &interval_zv);
1481+
zend_update_property(date_ce_period, &period_obj->std, "interval", sizeof("interval") - 1, &interval_zv);
1482+
zval_ptr_dtor(&interval_zv);
1483+
1484+
zend_update_property_long(date_ce_period, &period_obj->std, "recurrences", sizeof("recurrences") - 1, (zend_long) period_obj->recurrences);
1485+
zend_update_property_bool(date_ce_period, &period_obj->std, "include_start_date", sizeof("include_start_date") - 1, period_obj->include_start_date);
1486+
}
14351487

14361488
/* define an overloaded iterator structure */
14371489
typedef struct {
@@ -5275,58 +5327,3 @@ static zval *date_period_get_property_ptr_ptr(zend_object *object, zend_string *
52755327

52765328
return zend_std_get_property_ptr_ptr(object, name, type, cache_slot);
52775329
}
5278-
5279-
static void create_date_period_datetime(timelib_time *datetime, zend_class_entry *ce, zval *zv)
5280-
{
5281-
if (datetime) {
5282-
php_date_obj *date_obj;
5283-
object_init_ex(zv, ce);
5284-
date_obj = Z_PHPDATE_P(zv);
5285-
date_obj->time = timelib_time_clone(datetime);
5286-
} else {
5287-
ZVAL_NULL(zv);
5288-
}
5289-
}
5290-
5291-
static void create_date_period_interval(timelib_rel_time *interval, zval *zv)
5292-
{
5293-
if (interval) {
5294-
php_interval_obj *interval_obj;
5295-
object_init_ex(zv, date_ce_interval);
5296-
interval_obj = Z_PHPINTERVAL_P(zv);
5297-
interval_obj->diff = timelib_rel_time_clone(interval);
5298-
interval_obj->initialized = 1;
5299-
} else {
5300-
ZVAL_NULL(zv);
5301-
}
5302-
}
5303-
5304-
static void initialize_date_period_properties(php_period_obj *period_obj)
5305-
{
5306-
zval start_zv, current_zv, end_zv, interval_zv;
5307-
5308-
if (UNEXPECTED(!period_obj->std.properties)) {
5309-
rebuild_object_properties(&period_obj->std);
5310-
}
5311-
5312-
create_date_period_datetime(period_obj->start, period_obj->start_ce, &start_zv);
5313-
zend_update_property(date_ce_period, &period_obj->std, "start", sizeof("start") - 1, &start_zv);
5314-
zval_ptr_dtor(&start_zv);
5315-
5316-
create_date_period_datetime(period_obj->current, period_obj->start_ce, &current_zv);
5317-
zend_string *property_name = zend_string_init("current", sizeof("current") - 1, 0);
5318-
zend_std_write_property(&period_obj->std, property_name, &current_zv, NULL);
5319-
zval_ptr_dtor(&current_zv);
5320-
zend_string_release(property_name);
5321-
5322-
create_date_period_datetime(period_obj->end, period_obj->start_ce, &end_zv);
5323-
zend_update_property(date_ce_period, &period_obj->std, "end", sizeof("end") - 1, &end_zv);
5324-
zval_ptr_dtor(&end_zv);
5325-
5326-
create_date_period_interval(period_obj->interval, &interval_zv);
5327-
zend_update_property(date_ce_period, &period_obj->std, "interval", sizeof("interval") - 1, &interval_zv);
5328-
zval_ptr_dtor(&interval_zv);
5329-
5330-
zend_update_property_long(date_ce_period, &period_obj->std, "recurrences", sizeof("recurrences") - 1, (zend_long) period_obj->recurrences);
5331-
zend_update_property_bool(date_ce_period, &period_obj->std, "include_start_date", sizeof("include_start_date") - 1, period_obj->include_start_date);
5332-
}

‎ext/date/php_date.stub.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,7 @@ public static function __set_state(array $array): DateInterval {}
494494
class DatePeriod implements IteratorAggregate
495495
{
496496
public readonly ?DateTimeInterface $start;
497+
/** @readonly */
497498
public ?DateTimeInterface $current;
498499
public readonly ?DateTimeInterface $end;
499500
public readonly ?DateInterval $interval;

‎ext/date/php_date_arginfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 0073cb262ba1b9b5bcf211242c5ba1be9386ade9 */
2+
* Stub hash: 2de3e585385d35c18b05f8585117e805165b3cb6 */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_strtotime, 0, 1, MAY_BE_LONG|MAY_BE_FALSE)
55
ZEND_ARG_TYPE_INFO(0, datetime, IS_STRING, 0)

‎ext/date/tests/DatePeriod_serialize-001.phpt

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ echo "\n\nCalling __serialize manually:\n";
2020
var_dump($d->__serialize());
2121

2222
?>
23-
--EXPECT--
23+
--EXPECTF--
2424
Original object:
25-
object(DatePeriod)#1 (6) {
25+
object(DatePeriod)#%d (6) {
2626
["start"]=>
27-
object(DateTime)#2 (3) {
27+
object(DateTime)#%d (3) {
2828
["date"]=>
2929
string(26) "2012-07-01 00:00:00.000000"
3030
["timezone_type"]=>
@@ -37,7 +37,7 @@ object(DatePeriod)#1 (6) {
3737
["end"]=>
3838
NULL
3939
["interval"]=>
40-
object(DateInterval)#3 (10) {
40+
object(DateInterval)#%d (10) {
4141
["y"]=>
4242
int(0)
4343
["m"]=>
@@ -71,9 +71,9 @@ string(411) "O:10:"DatePeriod":6:{s:5:"start";O:8:"DateTime":3:{s:4:"date";s:26:
7171

7272

7373
Unserialised object:
74-
object(DatePeriod)#5 (6) {
74+
object(DatePeriod)#%d (6) {
7575
["start"]=>
76-
object(DateTime)#7 (3) {
76+
object(DateTime)#%d (3) {
7777
["date"]=>
7878
string(26) "2012-07-01 00:00:00.000000"
7979
["timezone_type"]=>
@@ -86,7 +86,7 @@ object(DatePeriod)#5 (6) {
8686
["end"]=>
8787
NULL
8888
["interval"]=>
89-
object(DateInterval)#8 (10) {
89+
object(DateInterval)#%d (10) {
9090
["y"]=>
9191
int(0)
9292
["m"]=>
@@ -118,7 +118,7 @@ object(DatePeriod)#5 (6) {
118118
Calling __serialize manually:
119119
array(6) {
120120
["start"]=>
121-
object(DateTime)#6 (3) {
121+
object(DateTime)#%d (3) {
122122
["date"]=>
123123
string(26) "2012-07-01 00:00:00.000000"
124124
["timezone_type"]=>
@@ -131,7 +131,7 @@ array(6) {
131131
["end"]=>
132132
NULL
133133
["interval"]=>
134-
object(DateInterval)#4 (10) {
134+
object(DateInterval)#%d (10) {
135135
["y"]=>
136136
int(0)
137137
["m"]=>

‎ext/date/tests/DatePeriod_serialize-002.phpt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ foreach ( $e as $d )
2828
echo $d->format(DateTime::ISO8601), "\n";
2929
}
3030
?>
31-
--EXPECT--
31+
--EXPECTF--
3232
Original object:
33-
object(DatePeriod)#4 (6) {
33+
object(DatePeriod)#%d (6) {
3434
["start"]=>
35-
object(DateTimeImmutable)#5 (3) {
35+
object(DateTimeImmutable)#%d (3) {
3636
["date"]=>
3737
string(26) "1978-12-22 09:15:00.000000"
3838
["timezone_type"]=>
@@ -43,7 +43,7 @@ object(DatePeriod)#4 (6) {
4343
["current"]=>
4444
NULL
4545
["end"]=>
46-
object(DateTimeImmutable)#6 (3) {
46+
object(DateTimeImmutable)#%d (3) {
4747
["date"]=>
4848
string(26) "2022-04-29 15:51:56.000000"
4949
["timezone_type"]=>
@@ -52,7 +52,7 @@ object(DatePeriod)#4 (6) {
5252
string(13) "Europe/London"
5353
}
5454
["interval"]=>
55-
object(DateInterval)#7 (10) {
55+
object(DateInterval)#%d (10) {
5656
["y"]=>
5757
int(2)
5858
["m"]=>
@@ -86,9 +86,9 @@ string(565) "O:10:"DatePeriod":6:{s:5:"start";O:17:"DateTimeImmutable":3:{s:4:"d
8686

8787

8888
Unserialised object:
89-
object(DatePeriod)#1 (6) {
89+
object(DatePeriod)#%d (6) {
9090
["start"]=>
91-
object(DateTimeImmutable)#11 (3) {
91+
object(DateTimeImmutable)#%d (3) {
9292
["date"]=>
9393
string(26) "1978-12-22 09:15:00.000000"
9494
["timezone_type"]=>
@@ -99,7 +99,7 @@ object(DatePeriod)#1 (6) {
9999
["current"]=>
100100
NULL
101101
["end"]=>
102-
object(DateTimeImmutable)#12 (3) {
102+
object(DateTimeImmutable)#%d (3) {
103103
["date"]=>
104104
string(26) "2022-04-29 15:51:56.000000"
105105
["timezone_type"]=>
@@ -108,7 +108,7 @@ object(DatePeriod)#1 (6) {
108108
string(13) "Europe/London"
109109
}
110110
["interval"]=>
111-
object(DateInterval)#13 (10) {
111+
object(DateInterval)#%d (10) {
112112
["y"]=>
113113
int(2)
114114
["m"]=>
@@ -140,7 +140,7 @@ object(DatePeriod)#1 (6) {
140140
Calling __serialize manually:
141141
array(6) {
142142
["start"]=>
143-
object(DateTimeImmutable)#2 (3) {
143+
object(DateTimeImmutable)#%d (3) {
144144
["date"]=>
145145
string(26) "1978-12-22 09:15:00.000000"
146146
["timezone_type"]=>
@@ -151,7 +151,7 @@ array(6) {
151151
["current"]=>
152152
NULL
153153
["end"]=>
154-
object(DateTimeImmutable)#8 (3) {
154+
object(DateTimeImmutable)#%d (3) {
155155
["date"]=>
156156
string(26) "2022-04-29 15:51:56.000000"
157157
["timezone_type"]=>
@@ -160,7 +160,7 @@ array(6) {
160160
string(13) "Europe/London"
161161
}
162162
["interval"]=>
163-
object(DateInterval)#9 (10) {
163+
object(DateInterval)#%d (10) {
164164
["y"]=>
165165
int(2)
166166
["m"]=>

‎ext/date/tests/DatePeriod_serialize-003.phpt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ foreach ( $e as $d )
2828
echo $d->format(DateTime::ISO8601), "\n";
2929
}
3030
?>
31-
--EXPECT--
31+
--EXPECTF--
3232
Original object:
33-
object(DatePeriod)#4 (6) {
33+
object(DatePeriod)#%d (6) {
3434
["start"]=>
35-
object(DateTimeImmutable)#5 (3) {
35+
object(DateTimeImmutable)#%d (3) {
3636
["date"]=>
3737
string(26) "1978-12-22 09:15:00.000000"
3838
["timezone_type"]=>
@@ -43,7 +43,7 @@ object(DatePeriod)#4 (6) {
4343
["current"]=>
4444
NULL
4545
["end"]=>
46-
object(DateTimeImmutable)#6 (3) {
46+
object(DateTimeImmutable)#%d (3) {
4747
["date"]=>
4848
string(26) "2022-04-29 15:51:56.000000"
4949
["timezone_type"]=>
@@ -52,7 +52,7 @@ object(DatePeriod)#4 (6) {
5252
string(13) "Europe/London"
5353
}
5454
["interval"]=>
55-
object(DateInterval)#7 (10) {
55+
object(DateInterval)#%d (10) {
5656
["y"]=>
5757
int(2)
5858
["m"]=>
@@ -86,9 +86,9 @@ string(565) "O:10:"DatePeriod":6:{s:5:"start";O:17:"DateTimeImmutable":3:{s:4:"d
8686

8787

8888
Unserialised object:
89-
object(DatePeriod)#1 (6) {
89+
object(DatePeriod)#%d (6) {
9090
["start"]=>
91-
object(DateTimeImmutable)#11 (3) {
91+
object(DateTimeImmutable)#%d (3) {
9292
["date"]=>
9393
string(26) "1978-12-22 09:15:00.000000"
9494
["timezone_type"]=>
@@ -99,7 +99,7 @@ object(DatePeriod)#1 (6) {
9999
["current"]=>
100100
NULL
101101
["end"]=>
102-
object(DateTimeImmutable)#12 (3) {
102+
object(DateTimeImmutable)#%d (3) {
103103
["date"]=>
104104
string(26) "2022-04-29 15:51:56.000000"
105105
["timezone_type"]=>
@@ -108,7 +108,7 @@ object(DatePeriod)#1 (6) {
108108
string(13) "Europe/London"
109109
}
110110
["interval"]=>
111-
object(DateInterval)#13 (10) {
111+
object(DateInterval)#%d (10) {
112112
["y"]=>
113113
int(2)
114114
["m"]=>
@@ -140,7 +140,7 @@ object(DatePeriod)#1 (6) {
140140
Calling __serialize manually:
141141
array(6) {
142142
["start"]=>
143-
object(DateTimeImmutable)#2 (3) {
143+
object(DateTimeImmutable)#%d (3) {
144144
["date"]=>
145145
string(26) "1978-12-22 09:15:00.000000"
146146
["timezone_type"]=>
@@ -151,7 +151,7 @@ array(6) {
151151
["current"]=>
152152
NULL
153153
["end"]=>
154-
object(DateTimeImmutable)#8 (3) {
154+
object(DateTimeImmutable)#%d (3) {
155155
["date"]=>
156156
string(26) "2022-04-29 15:51:56.000000"
157157
["timezone_type"]=>
@@ -160,7 +160,7 @@ array(6) {
160160
string(13) "Europe/London"
161161
}
162162
["interval"]=>
163-
object(DateInterval)#9 (10) {
163+
object(DateInterval)#%d (10) {
164164
["y"]=>
165165
int(2)
166166
["m"]=>

0 commit comments

Comments
 (0)