Ensure the internal properties cannot be overwritten

Author: duncan3dc

ext/date/php_date.c

@@ -5327,7 +5327,20 @@ static zval *date_period_read_property(zval *object, zval *member, int type, voi
 /* {{{ date_period_write_property */
 static void date_period_write_property(zval *object, zval *member, zval *value, void **cache_slot)
 {
-	zend_throw_error(NULL, "Writing to DatePeriod properties is unsupported");
+	if (!strcmp(Z_STRVAL_P(member), "recurrences")
+		|| !strcmp(Z_STRVAL_P(member), "include_start_date")
+		|| !strcmp(Z_STRVAL_P(member), "start")
+		|| !strcmp(Z_STRVAL_P(member), "current")
+		|| !strcmp(Z_STRVAL_P(member), "end")
+		|| !strcmp(Z_STRVAL_P(member), "interval")
+	) {
+		zend_string *name = zval_get_string(member);
+		zend_throw_error(NULL, "Writing to DatePeriod->%s is unsupported", ZSTR_VAL(name));
+		zend_string_release(name);
+		return;
+	}
+
+	std_object_handlers.write_property(object, member, value, cache_slot);
 }
 /* }}} */
 

ext/date/tests/DatePeriod_properties2.phpt

@@ -0,0 +1,34 @@
+--TEST--
+DatePeriod: Test cannot modify read only properties
+--INI--
+date.timezone=UTC
+--FILE--
+<?php
+
+$period = new DatePeriod(new DateTime, new DateInterval('P1D'), new DateTime);
+
+$properties = [
+    "recurrences",
+    "include_start_date",
+    "start",
+    "current",
+    "end",
+    "interval",
+];
+
+foreach ($properties as $property) {
+    try {
+        var_dump($period->$property = "new");
+    } catch (Error $e) {
+        echo $e->getMessage() . "\n";
+    }
+}
+
+?>
+--EXPECT--
+Writing to DatePeriod->recurrences is unsupported
+Writing to DatePeriod->include_start_date is unsupported
+Writing to DatePeriod->start is unsupported
+Writing to DatePeriod->current is unsupported
+Writing to DatePeriod->end is unsupported
+Writing to DatePeriod->interval is unsupported