Add tests for Attribut(flags: )

This doesn't work correctly yet.

Author: nikic

Zend/tests/named_params/attributes_named_flags.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Named flags parameter for Attribute attribute
+--FILE--
+<?php
+
+<<Attribute(flags: Attribute::TARGET_CLASS)>>
+class MyAttribute {
+}
+
+<<MyAttribute>>
+function test() {}
+
+(new ReflectionFunction('test'))->getAttributes()[0]->newInstance();
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Attribute "MyAttribute" cannot target function (allowed targets: class) in %s:%d
+Stack trace:
+#0 %s(%d): ReflectionAttribute->newInstance()
+#1 {main}
+  thrown in %s on line %d

Zend/tests/named_params/attributes_named_flags_incorrect.phpt

@@ -0,0 +1,22 @@
+--TEST--
+Named flags parameter for Attribute attribute (incorrect parameter name)
+--FILE--
+<?php
+
+// TODO: This should error at compile-time.
+<<Attribute(not_flags: Attribute::TARGET_CLASS)>>
+class MyAttribute {
+}
+
+<<MyAttribute>>
+function test() {}
+
+(new ReflectionFunction('test'))->getAttributes()[0]->newInstance();
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Attribute "MyAttribute" cannot target function (allowed targets: class) in %s:%d
+Stack trace:
+#0 %s(%d): ReflectionAttribute->newInstance()
+#1 {main}
+  thrown in %s on line %d

Zend/zend_attributes.c

@@ -29,6 +29,7 @@ static HashTable internal_attributes;
 
 void validate_attribute(zend_attribute *attr, uint32_t target, zend_class_entry *scope)
 {
+	// TODO: More proper signature validation: Too many args, incorrect arg names.
 	if (attr->argc > 0) {
 		zval flags;
 
@@ -121,7 +122,6 @@ ZEND_API int zend_get_attribute_value(zval *ret, zend_attribute *attr, uint32_t
 		return FAILURE;
 	}
 
-	// TODO: Named args.
 	ZVAL_COPY_OR_DUP(ret, &attr->args[i].value);
 
 	if (Z_TYPE_P(ret) == IS_CONSTANT_AST) {