Add missing error check on PEM_write_bio_CMS()

nielsdos · nielsdos · commit 460d2f3b825a · 2023-03-02T17:20:45.000+01:00
On failure, this function returns 0. 2 other callers of this function
already check the return value, but this one was missed.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -5989,7 +5989,11 @@ PHP_FUNCTION(openssl_cms_verify)
 			}
 
 			if (p7bout) {
-				PEM_write_bio_CMS(p7bout, cms);
+				if (PEM_write_bio_CMS(p7bout, cms) == 0) {
+					php_error_docref(NULL, E_WARNING, "Failed to write CMS to BIO");
+					php_openssl_store_errors();
+					RETVAL_FALSE;
+				}
 			}
 		}
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -5989,7 +5989,11 @@ PHP_FUNCTION(openssl_cms_verify)`
`5989`	`5989`	`}`
`5990`	`5990`
`5991`	`5991`	`if (p7bout) {`
`5992`		`- PEM_write_bio_CMS(p7bout, cms);`
	`5992`	`+ if (PEM_write_bio_CMS(p7bout, cms) == 0) {`
	`5993`	`+ php_error_docref(NULL, E_WARNING, "Failed to write CMS to BIO");`
	`5994`	`+ php_openssl_store_errors();`
	`5995`	`+ RETVAL_FALSE;`
	`5996`	`+ }`
`5993`	`5997`	`}`
`5994`	`5998`	`}`
`5995`	`5999`	`} else {`