Skip to content

Commit 48198e4

Browse files
committed
Fix #68302: impossible to compile php with zip support
We should not let configure succeed, if SIZEOF_OFF_T == 0, just to let the compilation fail later. Instead we bail out early, giving a hint regarding the potential issue, namely misconfigured libraries.
1 parent abe0090 commit 48198e4

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ PHP NEWS
3131
- XML:
3232
. Fixed bug #72085 (SEGV on unknown address zif_xml_parse). (cmb)
3333

34+
- ZIP:
35+
. Fixed bug #68302 (impossible to compile php with zip support). (cmb)
36+
3437
18 Aug 2016, PHP 5.6.25
3538

3639
- Bz2:

ext/zip/config.m4

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,9 @@ AC_CHECK_SIZEOF([int])
148148
AC_CHECK_SIZEOF([long])
149149
AC_CHECK_SIZEOF([long long])
150150
AC_CHECK_SIZEOF([off_t])
151+
if test "$ac_cv_sizeof_off_t" = "0" ; then
152+
AC_MSG_ERROR(off_t undefined; check your library configuration)
153+
fi
151154
AC_CHECK_SIZEOF([size_t])
152155

153156
AC_PATH_PROG([TOUCH], [touch])

0 commit comments

Comments
 (0)