WIP: run-tests: add skip cache

Executing PHP every time a test specifies a skip condition is kinda
wasteful. Since skip conditions are often similar, just have a cache
of them.

On my machine, the gains are quite noticeable: 36s instead of 43s
with -j16, 253s instead of 302s without concurrency. Cache stats are
3420 hits, 1066 misses in the latter case. Needs more work and a fix
for a failing test. Future improvements could be also caching enabled
extensions and normalizing skip code across tests to improve hit ratio.

Author: MaxSem

run-tests.php

@@ -1833,6 +1833,11 @@ function run_test(string $php, $file, array $env): string
     /** @var JUnit */
     global $junit;
 
+    static $skipChecker;
+    if (!$skipChecker) {
+        $skipChecker = new SkipChecker();
+    }
+
     $temp_filenames = null;
     $org_file = $file;
 
@@ -2218,7 +2223,7 @@ function run_test(string $php, $file, array $env): string
     if (array_key_exists('SKIPIF', $section_text)) {
         if (trim($section_text['SKIPIF'])) {
             show_file_block('skip', $section_text['SKIPIF']);
-            save_text($test_skipif, $section_text['SKIPIF'], $temp_skipif);
+            //save_text($test_skipif, $section_text['SKIPIF'], $temp_skipif);
             $extra = !IS_WINDOWS ?
                 "unset REQUEST_METHOD; unset QUERY_STRING; unset PATH_TRANSLATED; unset SCRIPT_FILENAME; unset REQUEST_METHOD;" : "";
 
@@ -2230,7 +2235,10 @@ function run_test(string $php, $file, array $env): string
             $junit->startTimer($shortname);
 
             $startTime = microtime(true);
-            $output = system_with_timeout("$extra $php $pass_options $extra_options -q $orig_ini_settings $no_file_cache -d display_errors=1 -d display_startup_errors=0 \"$test_skipif\"", $env);
+            $commandLine = "$extra $php $pass_options $extra_options -q $orig_ini_settings $no_file_cache -d display_errors=1 -d display_startup_errors=0";
+            $output = $skipChecker->checkSkip($commandLine, $section_text['SKIPIF'], $test_skipif);
+
+            //$output = system_with_timeout("$extra $php $pass_options $extra_options -q $orig_ini_settings $no_file_cache -d display_errors=1 -d display_startup_errors=0 \"$test_skipif\"", $env);
             $output = trim($output);
             $time = microtime(true) - $startTime;
 
@@ -3716,6 +3724,36 @@ private function mergeSuites(array &$dest, array $source): void
     }
 }
 
+class SkipChecker
+{
+    private array $skips = [];
+    private array $extensions = [];
+
+    private int $hits = 0;
+    private int $misses = 0;
+
+    public function checkSkip(string $php, string $code, string $checkFile): string
+    {
+        if (isset($this->skips[$php][$code])) {
+            $this->hits++;
+            return $this->skips[$php][$code];
+        }
+
+        global $env;
+        save_text($checkFile, $code);
+        $result = system_with_timeout("$php \"$checkFile\"", $env);
+        $this->skips[$php][$code] = $result;
+        $this->misses++;
+
+        return $result;
+    }
+
+//    public function __destruct()
+//    {
+//        echo "{$this->hits} hits, {$this->misses} misses.\n";
+//    }
+}
+
 class RuntestsValgrind
 {
     protected $version = '';