Skip to content

Commit 4a8e9fa

Browse files
committed
Use RETVAL_BOOL or RETURN_BOOL in ext/tidy
1 parent e77cb68 commit 4a8e9fa

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

ext/tidy/tidy.c

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1430,12 +1430,8 @@ PHP_METHOD(tidy, parseFile)
14301430
RETURN_THROWS();
14311431
}
14321432

1433-
if (php_tidy_apply_config(obj->ptdoc->doc, options_str, options_ht) != SUCCESS
1434-
|| php_tidy_parse_string(obj, ZSTR_VAL(contents), (uint32_t)ZSTR_LEN(contents), enc) != SUCCESS) {
1435-
RETVAL_FALSE;
1436-
} else {
1437-
RETVAL_TRUE;
1438-
}
1433+
RETVAL_BOOL(php_tidy_apply_config(obj->ptdoc->doc, options_str, options_ht) != SUCCESS
1434+
|| php_tidy_parse_string(obj, ZSTR_VAL(contents), (uint32_t)ZSTR_LEN(contents), enc) != SUCCESS);
14391435

14401436
zend_string_release_ex(contents, 0);
14411437
}
@@ -1463,12 +1459,8 @@ PHP_METHOD(tidy, parseString)
14631459
TIDY_SET_CONTEXT;
14641460
obj = Z_TIDY_P(object);
14651461

1466-
if (php_tidy_apply_config(obj->ptdoc->doc, options_str, options_ht) == SUCCESS
1467-
&& php_tidy_parse_string(obj, ZSTR_VAL(input), (uint32_t)ZSTR_LEN(input), enc) == SUCCESS) {
1468-
RETURN_TRUE;
1469-
}
1470-
1471-
RETURN_FALSE;
1462+
RETURN_BOOL(php_tidy_apply_config(obj->ptdoc->doc, options_str, options_ht) == SUCCESS
1463+
&& php_tidy_parse_string(obj, ZSTR_VAL(input), (uint32_t)ZSTR_LEN(input), enc) == SUCCESS);
14721464
}
14731465

14741466

0 commit comments

Comments
 (0)