Skip to content

Commit 523e03f

Browse files
committed
1 parent f0b3e3b commit 523e03f

File tree

5 files changed

+6
-28
lines changed

5 files changed

+6
-28
lines changed

NEWS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ PHP NEWS
1313
- DOM:
1414
. Fixed bug GH-15192 (Segmentation fault in dom extension
1515
(html5_serializer)). (nielsdos)
16+
. Removed DOMImplementation::getFeature(). (nielsdos)
1617

1718
- PHPDBG:
1819
. array out of bounds, stack overflow handled for segfault handler on windows.

UPGRADING

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -757,6 +757,10 @@ PHP 8.4 UPGRADE NOTES
757757
- Date:
758758
. The class constants are typed now.
759759

760+
- DOM:
761+
. Removed DOMImplementation::getFeature().
762+
RFC: https://wiki.php.net/rfc/deprecations_php_8_4#remove_domimplementationgetfeature_feature_version
763+
760764
- Intl:
761765
. The class constants are typed now.
762766
. The behaviour of Intl class has been normalized to always throw Error

ext/dom/domimplementation.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -415,21 +415,4 @@ PHP_METHOD(Dom_Implementation, createHTMLDocument)
415415
}
416416
/* }}} */
417417

418-
/* {{{ URL: http://www.w3.org/TR/2003/WD-DOM-Level-3-Core-20030226/DOM3-Core.html#DOMImplementation3-getFeature
419-
Since: DOM Level 3
420-
*/
421-
PHP_METHOD(DOMImplementation, getFeature)
422-
{
423-
size_t feature_len, version_len;
424-
char *feature, *version;
425-
426-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "ss", &feature, &feature_len, &version, &version_len) == FAILURE) {
427-
RETURN_THROWS();
428-
}
429-
430-
zend_throw_error(NULL, "Not yet implemented");
431-
RETURN_THROWS();
432-
}
433-
/* }}} end dom_domimplementation_get_feature */
434-
435418
#endif

ext/dom/php_dom.stub.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -453,9 +453,6 @@ public function __wakeup(): void {}
453453

454454
class DOMImplementation
455455
{
456-
/** @tentative-return-type */
457-
public function getFeature(string $feature, string $version): never {}
458-
459456
/** @tentative-return-type */
460457
public function hasFeature(string $feature, string $version): bool {}
461458

ext/dom/php_dom_arginfo.h

Lines changed: 1 addition & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)