Implement review

Author: Girgias

ext/standard/array.c

@@ -2457,19 +2457,18 @@ PHP_FUNCTION(extract)
 	}
 
 	if (extract_type > EXTR_SKIP && extract_type <= EXTR_PREFIX_IF_EXISTS && ZEND_NUM_ARGS() < 3) {
-		zend_throw_error(NULL, "specified extract type requires the prefix parameter");
+		zend_throw_error(NULL, "Specified extract type requires the prefix parameter");
 		return;
 	}
 
 	if (prefix) {
 		if (ZSTR_LEN(prefix) && !php_valid_var_name(ZSTR_VAL(prefix), ZSTR_LEN(prefix))) {
-			zend_throw_error(NULL, "prefix is not a valid identifier");
+			zend_throw_error(NULL, "Prefix is not a valid identifier");
 			return;
 		}
 	}
 
 	if (zend_forbid_dynamic_call("extract()") == FAILURE) {
-		/* TODO Elevate to exception ? */
 		return;
 	}
 

ext/standard/tests/array/extract_error.phpt

@@ -36,5 +36,5 @@ echo "Done\n";
 Notice: A non well formed numeric value encountered in %s on line %d
 Invalid extract type
 Invalid extract type
-specified extract type requires the prefix parameter
+Specified extract type requires the prefix parameter
 Done