Skip to content

Commit 57896cf

Browse files
carusogabrielnikic
authored andcommitted
Make some skipped tests run, and fix some skip messages
1 parent 2bd7e2b commit 57896cf

File tree

3 files changed

+11
-17
lines changed

3 files changed

+11
-17
lines changed

ext/date/tests/gmstrftime_variation9.phpt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
--TEST--
2-
Test gmstrftime() function : usage variation - Checking week related formats which was not supported on Windows before vc14.
2+
Test gmstrftime() function : usage variation - Checking week related formats which was not supported on Windows before vc14.
33
--SKIPIF--
44
<?php
55
if (strtoupper(substr(PHP_OS, 0, 3)) != 'WIN') {
6-
die("skip Test is not valid for Windows");
6+
die("skip Test is only valid for Windows");
77
}
88
?>
99
--FILE--
1010
<?php
1111
/* Prototype : string gmstrftime(string format [, int timestamp])
12-
* Description: Format a GMT/UCT time/date according to locale settings
12+
* Description: Format a GMT/UCT time/date according to locale settings
1313
* Source code: ext/date/php_date.c
14-
* Alias to functions:
14+
* Alias to functions:
1515
*/
1616

1717
echo "*** Testing gmstrftime() : usage variation ***\n";

ext/filter/tests/bug52209.phpt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,18 @@
22
Bug #52209 (INPUT_ENV returns NULL for set variables (CLI))
33
--SKIPIF--
44
<?php
5-
/* This test makes no sense on windows as an empty variable
6-
would never show up in the "set" list. Which means, it's
5+
/* This test makes no sense on windows as an empty variable
6+
would never show up in the "set" list. Which means, it's
77
always undefined in PHP. */
88
if(substr(PHP_OS, 0, 3) == "WIN") die("skip Not for Windows");
9-
if (!extension_loaded("filter") || !empty($_ENV['PWD'])) die("skip");
9+
if (!extension_loaded("filter")) die ('skip filter extension not loaded');
10+
if (empty($_ENV['PWD'])) die('skip PWD is empty');
1011
?>
1112
--INI--
1213
variables_order=GPCSE
1314
--FILE--
1415
<?php
1516
var_dump(filter_input(INPUT_ENV, 'PWD'));
1617
?>
17-
--EXPECTF--
18+
--EXPECTF--
1819
string(%d) "%s"

ext/soap/tests/bugs/bug34657.phpt

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
11
--TEST--
22
Bug #34657 (If you get a communication problem when loading the WSDL, it fatal's)
33
--SKIPIF--
4-
<?php
5-
require_once('skipif.inc');
6-
if (extension_loaded("openssl")) {
7-
/*
8-
when openssl loaded, tcp stream is less verbose, so some error messages are missing
9-
so let's skip the test in this case
10-
*/
11-
die("skip OpenSSL extension required");
12-
}
4+
<?php
5+
require_once('skipif.inc');
136
?>
147
--FILE--
158
<?php

0 commit comments

Comments
 (0)