address review comments

Author: Girgias

ext/session/session.c

@@ -704,11 +704,13 @@ static PHP_INI_MH(OnUpdateName) /* {{{ */
 		}
 		return FAILURE;
 	}
-	/* Numeric session.name won't work at all */
+	/* Numeric session.name won't work at all
+	 * See https://bugs.php.net/bug.php?id=35703
+	 (TL;DR: name is stored in HashTable so numeric string is converted to int key, but lookup looks for string key). */
 	if (is_numeric_str_function(new_value, NULL, NULL)) {
 		/* Do not output error when restoring ini options. */
 		if (stage != ZEND_INI_STAGE_DEACTIVATE) {
-			php_error_docref(NULL, err_type, "session.name \"%s\" cannot be numeric or empty", ZSTR_VAL(new_value));
+			php_error_docref(NULL, err_type, "session.name \"%s\" cannot be numeric", ZSTR_VAL(new_value));
 		}
 		return FAILURE;
 	}

ext/session/tests/session_name_variation1.phpt

@@ -15,6 +15,24 @@ ob_start();
 
 echo "*** Testing session_name() : variation ***\n";
 
+var_dump(session_name("\0"));
+var_dump(session_start());
+var_dump(session_name());
+var_dump(session_destroy());
+var_dump(session_name());
+
+var_dump(session_name("15"));
+var_dump(session_start());
+var_dump(session_name());
+var_dump(session_destroy());
+var_dump(session_name());
+
+var_dump(session_name("10.25"));
+var_dump(session_start());
+var_dump(session_name());
+var_dump(session_destroy());
+var_dump(session_name());
+
 var_dump(session_name("\t"));
 var_dump(session_start());
 var_dump(session_name());
@@ -33,7 +51,21 @@ ob_end_flush();
 --EXPECTF--
 *** Testing session_name() : variation ***
 
-Warning: session_name(): session.name "" cannot contain nul bytes in %s on line %d
+Warning: session_name(): session.name "" cannot contain NUL bytes in %s on line %d
+string(9) "PHPSESSID"
+bool(true)
+string(9) "PHPSESSID"
+bool(true)
+string(9) "PHPSESSID"
+
+Warning: session_name(): session.name "15" cannot be numeric in %s on line %d
+string(9) "PHPSESSID"
+bool(true)
+string(9) "PHPSESSID"
+bool(true)
+string(9) "PHPSESSID"
+
+Warning: session_name(): session.name "10.25" cannot be numeric in %s on line %d
 string(9) "PHPSESSID"
 
 Warning: session_start(): session.name cannot contain any of the following '=,;.[ \t\r\n\013\014' in %s on line %d