ext/intl IntlChar::enumCharNames changes the signature to void.

Author: devnexen

UPGRADING

@@ -81,6 +81,8 @@ PHP 8.3 UPGRADE NOTES
 - Intl:
   . datefmt_set_timezone (and its alias IntlDateformatter::setTimeZone) 
     now returns true on sucess, previously null was returned.
+  . IntlChar::enumCharNames is now a void method.
+    Previously it returned null on success and false on failure.
 
 - MBString:
   . mb_strtolower, mb_strtotitle, and mb_convert_case implement conditional

ext/intl/intl_data.h

@@ -61,6 +61,14 @@ typedef struct _intl_data {
         RETURN_NULL();                           \
     }
 
+/* Check status by error code, if error return directly */
+#define INTL_CHECK_STATUS_RETURN(err, msg)											\
+    intl_error_set_code( NULL, (err) );							\
+    if( U_FAILURE((err)) )													\
+    {																		\
+        intl_error_set_custom_msg( NULL, msg, 0 );				\
+        return;														\
+    }
 
 /* Check status in object, if error return false */
 #define INTL_METHOD_CHECK_STATUS(obj, msg)											\

ext/intl/uchar/uchar.c

@@ -309,11 +309,11 @@ IC_METHOD(enumCharNames) {
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (convert_cp(&start, string_start, int_start) == FAILURE || convert_cp(&limit, string_limit, int_limit) == FAILURE) {
-		RETURN_NULL();
+		return;
 	}
 
 	u_enumCharNames(start, limit, (UEnumCharNamesFn*)enumCharNames_callback, &context, nameChoice, &error);
-	INTL_CHECK_STATUS(error, NULL);
+	INTL_CHECK_STATUS_RETURN(error, NULL);
 }
 /* }}} */
 

ext/intl/uchar/uchar.stub.php

@@ -3411,7 +3411,7 @@ public static function chr(int|string $codepoint): ?string {}
     public static function digit(int|string $codepoint, int $base = 10): int|false|null {}
 
     /** @tentative-return-type */
-    public static function enumCharNames(int|string $start, int|string $end, callable $callback, int $type = IntlChar::UNICODE_CHAR_NAME): ?bool {} // TODO return values just don't make sense
+    public static function enumCharNames(int|string $start, int|string $end, callable $callback, int $type = IntlChar::UNICODE_CHAR_NAME): void {}
 
     /** @tentative-return-type */
     public static function enumCharTypes(callable $callback): void {}