Add a new test to check new deprecations

Author: kamil-tekiela

ext/session/session.c

@@ -832,6 +832,16 @@ static PHP_INI_MH(OnUpdateUseTransSid)
 	return SUCCESS;
 }
 
+static PHP_INI_MH(OnUpdateRefererCheck)
+{
+	SESSION_CHECK_ACTIVE_STATE;
+	SESSION_CHECK_OUTPUT_STATE;
+	if (strcmp("", ZSTR_VAL(new_value)) != 0) {
+		php_error_docref(NULL, E_DEPRECATED, "Usage of session.referer_check INI setting is deprecated");
+	}
+	return OnUpdateString(entry, new_value, mh_arg1, mh_arg2, mh_arg3, stage);
+}
+
 /* {{{ PHP_INI */
 PHP_INI_BEGIN()
 	STD_PHP_INI_ENTRY("session.save_path",          "",          PHP_INI_ALL, OnUpdateSaveDir,       save_path,          php_ps_globals,    ps_globals)
@@ -851,7 +861,7 @@ PHP_INI_BEGIN()
 	STD_PHP_INI_BOOLEAN("session.use_cookies",      "1",         PHP_INI_ALL, OnUpdateSessionBool,   use_cookies,        php_ps_globals,    ps_globals)
 	STD_PHP_INI_BOOLEAN("session.use_only_cookies", "1",         PHP_INI_ALL, OnUpdateUseOnlyCookies,   use_only_cookies,   php_ps_globals,    ps_globals)
 	STD_PHP_INI_BOOLEAN("session.use_strict_mode",  "0",         PHP_INI_ALL, OnUpdateSessionBool,   use_strict_mode,    php_ps_globals,    ps_globals)
-	STD_PHP_INI_ENTRY("session.referer_check",      "",          PHP_INI_ALL, OnUpdateSessionString, extern_referer_chk, php_ps_globals,    ps_globals)
+	STD_PHP_INI_ENTRY("session.referer_check",      "",          PHP_INI_ALL, OnUpdateRefererCheck, extern_referer_chk, php_ps_globals,    ps_globals)
 	STD_PHP_INI_ENTRY("session.cache_limiter",      "nocache",   PHP_INI_ALL, OnUpdateSessionString, cache_limiter,      php_ps_globals,    ps_globals)
 	STD_PHP_INI_ENTRY("session.cache_expire",       "180",       PHP_INI_ALL, OnUpdateSessionLong,   cache_expire,       php_ps_globals,    ps_globals)
 	STD_PHP_INI_BOOLEAN("session.use_trans_sid",    "0",         PHP_INI_ALL, OnUpdateUseTransSid,   use_trans_sid,      php_ps_globals,    ps_globals)

ext/session/tests/deprecations.phpt

@@ -0,0 +1,58 @@
+--TEST--
+Deprecated GET/POST sessions
+--EXTENSIONS--
+session
+--SKIPIF--
+<?php include 'skipif.inc'; ?>
+--INI--
+session.use_cookies=0
+session.use_only_cookies=1
+session.use_trans_sid=0
+--FILE--
+<?php
+
+ob_start();
+
+// Expecting deprecation here
+ini_set("session.use_only_cookies", "0");
+// Expecting no deprecation
+ini_set("session.use_only_cookies", "1");
+
+// Expecting deprecation here
+ini_set("session.use_trans_sid", "1");
+// Expecting no deprecation
+ini_set("session.use_trans_sid", "0");
+
+// Expecting deprecation here
+ini_set("session.trans_sid_tags", "a=href");
+// Expecting no deprecation (default value)
+ini_set("session.trans_sid_tags", "a=href,area=href,frame=src,form=");
+
+// Expecting deprecation here
+ini_set("session.trans_sid_hosts", "php.net");
+// Expecting no deprecation (default value)
+ini_set("session.trans_sid_hosts", "");
+
+// Expecting deprecation here
+ini_set("session.referer_check", "php.net");
+// Expecting no deprecation (default value)
+ini_set("session.referer_check", "");
+
+// Setting deprecated values directly in session_start()
+// Expecting deprecation here
+session_start([ 'use_cookies' => '0', 'use_only_cookies' => '0', 'use_trans_sid' => '1']);
+?>
+--EXPECTF--
+Deprecated: ini_set(): Disabling session.use_only_cookies INI setting is deprecated in %s on line 6
+
+Deprecated: ini_set(): Enabling session.use_trans_sid INI setting is deprecated in %s on line 11
+
+Deprecated: ini_set(): Usage of session.trans_sid_tags INI setting is deprecated in %s on line 16
+
+Deprecated: ini_set(): Usage of session.trans_sid_hosts INI setting is deprecated in %s on line 21
+
+Deprecated: ini_set(): Usage of session.referer_check INI setting is deprecated in %s on line 26
+
+Deprecated: session_start(): Disabling session.use_only_cookies INI setting is deprecated in %s on line 32
+
+Deprecated: session_start(): Enabling session.use_trans_sid INI setting is deprecated in %s on line 32

ext/standard/url_scanner_ex.re

@@ -102,6 +102,9 @@ static zend_result php_ini_on_update_tags(zend_ini_entry *entry, zend_string *ne
 
 static PHP_INI_MH(OnUpdateSessionTags)
 {
+	if (strcmp("a=href,area=href,frame=src,form=", ZSTR_VAL(new_value)) != 0) {
+		php_error_docref(NULL, E_DEPRECATED, "Usage of session.trans_sid_tags INI setting is deprecated");
+	}
 	return php_ini_on_update_tags(entry, new_value, mh_arg1, mh_arg2, mh_arg3, stage, /* is_session */ true);
 }
 
@@ -152,6 +155,9 @@ static zend_result php_ini_on_update_hosts(zend_ini_entry *entry, zend_string *n
 
 static PHP_INI_MH(OnUpdateSessionHosts)
 {
+	if (strcmp("", ZSTR_VAL(new_value)) != 0) {
+		php_error_docref(NULL, E_DEPRECATED, "Usage of session.trans_sid_hosts INI setting is deprecated");
+	}
 	return php_ini_on_update_hosts(entry, new_value, mh_arg1, mh_arg2, mh_arg3, stage, /* is_session */ true);
 }