Skip to content

Commit 70ff3c3

Browse files
committed
Merge branch 'PHP-8.1' into PHP-8.2
* PHP-8.1: Fixed possible use-after-free
2 parents 5e1058b + 2297e8c commit 70ff3c3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ext/opcache/jit/zend_jit_trace.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2724,15 +2724,15 @@ static zend_lifetime_interval** zend_jit_trace_allocate_registers(zend_jit_trace
27242724
ZEND_ASSERT(ssa->var_info != NULL);
27252725

27262726
start = do_alloca(sizeof(int) * ssa->vars_count * 2 +
2727-
ZEND_MM_ALIGNED_SIZE(sizeof(uint8_t) * ssa->vars_count) +
2728-
ZEND_MM_ALIGNED_SIZE(sizeof(zend_op_array*) * ssa->vars_count),
2727+
ZEND_MM_ALIGNED_SIZE(sizeof(uint8_t) * ssa->vars_count),
27292728
use_heap);
27302729
if (!start) {
27312730
return NULL;
27322731
}
27332732
end = start + ssa->vars_count;
27342733
flags = (uint8_t*)(end + ssa->vars_count);
2735-
vars_op_array = (const zend_op_array**)(flags + ZEND_MM_ALIGNED_SIZE(sizeof(uint8_t) * ssa->vars_count));
2734+
checkpoint = zend_arena_checkpoint(CG(arena));
2735+
vars_op_array = zend_arena_calloc(&CG(arena), ssa->vars_count, sizeof(zend_op_array*));
27362736

27372737
memset(start, -1, sizeof(int) * ssa->vars_count * 2);
27382738
memset(flags, 0, sizeof(uint8_t) * ssa->vars_count);
@@ -3127,10 +3127,10 @@ static zend_lifetime_interval** zend_jit_trace_allocate_registers(zend_jit_trace
31273127

31283128
if (!count) {
31293129
free_alloca(start, use_heap);
3130+
zend_arena_release(&CG(arena), checkpoint);
31303131
return NULL;
31313132
}
31323133

3133-
checkpoint = zend_arena_checkpoint(CG(arena));
31343134
intervals = zend_arena_calloc(&CG(arena), ssa->vars_count, sizeof(zend_lifetime_interval));
31353135
memset(intervals, 0, sizeof(zend_lifetime_interval*) * ssa->vars_count);
31363136
list = zend_arena_alloc(&CG(arena), sizeof(zend_lifetime_interval) * count);

0 commit comments

Comments
 (0)