Remove useless RETURN_NULLs() (#14350)

nielsdos · web-flow · commit 7278364f9c28 · 2024-05-28T22:59:37.000+02:00
These functions are void, their use of RETURN_NULL() was mildly
confusing.
diff --git a/ext/dom/element.c b/ext/dom/element.c
@@ -1318,8 +1318,6 @@ PHP_METHOD(DOMElement, setIdAttribute)
 	} else {
 		php_set_attribute_id(attrp, is_id);
 	}
-
-	RETURN_NULL();
 }
 /* }}} end dom_element_set_id_attribute */
 
@@ -1349,8 +1347,6 @@ PHP_METHOD(DOMElement, setIdAttributeNS)
 	} else {
 		php_set_attribute_id(attrp, is_id);
 	}
-
-	RETURN_NULL();
 }
 /* }}} end dom_element_set_id_attribute_ns */
 
@@ -1378,8 +1374,6 @@ static void dom_element_set_id_attribute_node(INTERNAL_FUNCTION_PARAMETERS, zend
 	} else {
 		php_set_attribute_id(attrp, is_id);
 	}
-
-	RETURN_NULL();
 }
 
 PHP_METHOD(DOMElement, setIdAttributeNode)

Original file line number	Diff line number	Diff line change
`@@ -1318,8 +1318,6 @@ PHP_METHOD(DOMElement, setIdAttribute)`
`1318`	`1318`	`} else {`
`1319`	`1319`	`php_set_attribute_id(attrp, is_id);`
`1320`	`1320`	`}`
`1321`		`-`
`1322`		`- RETURN_NULL();`
`1323`	`1321`	`}`
`1324`	`1322`	`/* }}} end dom_element_set_id_attribute */`
`1325`	`1323`
`@@ -1349,8 +1347,6 @@ PHP_METHOD(DOMElement, setIdAttributeNS)`
`1349`	`1347`	`} else {`
`1350`	`1348`	`php_set_attribute_id(attrp, is_id);`
`1351`	`1349`	`}`
`1352`		`-`
`1353`		`- RETURN_NULL();`
`1354`	`1350`	`}`
`1355`	`1351`	`/* }}} end dom_element_set_id_attribute_ns */`
`1356`	`1352`
`@@ -1378,8 +1374,6 @@ static void dom_element_set_id_attribute_node(INTERNAL_FUNCTION_PARAMETERS, zend`
`1378`	`1374`	`} else {`
`1379`	`1375`	`php_set_attribute_id(attrp, is_id);`
`1380`	`1376`	`}`
`1381`		`-`
`1382`		`- RETURN_NULL();`
`1383`	`1377`	`}`
`1384`	`1378`
`1385`	`1379`	`PHP_METHOD(DOMElement, setIdAttributeNode)`