Skip to content

Commit 73efa35

Browse files
committed
increasing the minimum (stable) release support to 3.25.3
can be discussed but is not too far in the past, not too recent neither.
1 parent 99b77e4 commit 73efa35

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

build/php.m4

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1923,7 +1923,7 @@ dnl
19231923
dnl Common setup macro for SQLite library.
19241924
dnl
19251925
AC_DEFUN([PHP_SETUP_SQLITE], [
1926-
PKG_CHECK_MODULES([SQLITE], [sqlite3 >= 3.7.7], [
1926+
PKG_CHECK_MODULES([SQLITE], [sqlite3 >= 3.25.3], [
19271927
PHP_EVAL_INCLINE([$SQLITE_CFLAGS])
19281928
PHP_EVAL_LIBLINE([$SQLITE_LIBS], [$1])
19291929
])

ext/pdo_sqlite/sqlite_statement.c

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -375,21 +375,17 @@ static int pdo_sqlite_stmt_get_attribute(pdo_stmt_t *stmt, zend_long attr, zval
375375
case PDO_SQLITE_ATTR_READONLY_STATEMENT:
376376
ZVAL_FALSE(val);
377377

378-
#if SQLITE_VERSION_NUMBER >= 3007004 // Should we still keep it ? avail. since circa 2010
379-
if (sqlite3_stmt_readonly(S->stmt)) {
380-
ZVAL_TRUE(val);
381-
}
382-
#endif
378+
if (sqlite3_stmt_readonly(S->stmt)) {
379+
ZVAL_TRUE(val);
380+
}
383381
break;
384382

385383
case PDO_SQLITE_ATTR_BUSY_STATEMENT:
386384
ZVAL_FALSE(val);
387385

388-
#if SQLITE_VERSION_NUMBER >= 3007004
389-
if (sqlite3_stmt_busy(S->stmt)) {
390-
ZVAL_TRUE(val);
391-
}
392-
#endif
386+
if (sqlite3_stmt_busy(S->stmt)) {
387+
ZVAL_TRUE(val);
388+
}
393389
break;
394390
default:
395391
return 0;

0 commit comments

Comments
 (0)