fixup! Implement the "Redacting parameters in back traces" RFC

Author: TimWolla

Zend/tests/function_arguments/sensitive_parameter_value_no_dynamic_property.phpt

@@ -0,0 +1,15 @@
+--TEST--
+A SensitiveParameterValue does not allow dynamic properties.
+--FILE--
+<?php
+
+$v = new SensitiveParameterValue('secret');
+
+$v->foo = 'bar';
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Cannot create dynamic property SensitiveParameterValue::$foo in %ssensitive_parameter_value_no_dynamic_property.php:5
+Stack trace:
+#0 {main}
+  thrown in %ssensitive_parameter_value_no_dynamic_property.php on line 5

Zend/zend_attributes.stub.php

@@ -19,11 +19,17 @@ final class AllowDynamicProperties
     public function __construct() {}
 }
 
+/**
+ * @strict-properties
+ */
 final class SensitiveParameter
 {
     public function __construct() {}
 }
 
+/**
+ * @strict-properties
+ */
 final class SensitiveParameterValue
 {
     private readonly mixed $value;

Zend/zend_attributes_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: dad2a0b36a6868cb6a15b600d12e155c40779114 */
+ * Stub hash: f483cdaeb4123e65d6a1e29ce4ecb4f68b54d69b */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Attribute___construct, 0, 0, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, flags, IS_LONG, 0, "Attribute::TARGET_ALL")
@@ -118,7 +118,7 @@ static zend_class_entry *register_class_SensitiveParameter(void)
 
 	INIT_CLASS_ENTRY(ce, "SensitiveParameter", class_SensitiveParameter_methods);
 	class_entry = zend_register_internal_class_ex(&ce, NULL);
-	class_entry->ce_flags |= ZEND_ACC_FINAL;
+	class_entry->ce_flags |= ZEND_ACC_FINAL|ZEND_ACC_NO_DYNAMIC_PROPERTIES;
 
 	return class_entry;
 }
@@ -129,7 +129,7 @@ static zend_class_entry *register_class_SensitiveParameterValue(void)
 
 	INIT_CLASS_ENTRY(ce, "SensitiveParameterValue", class_SensitiveParameterValue_methods);
 	class_entry = zend_register_internal_class_ex(&ce, NULL);
-	class_entry->ce_flags |= ZEND_ACC_FINAL;
+	class_entry->ce_flags |= ZEND_ACC_FINAL|ZEND_ACC_NO_DYNAMIC_PROPERTIES;
 
 	zval property_value_default_value;
 	ZVAL_UNDEF(&property_value_default_value);