Skip to content

Commit 7e09d1c

Browse files
committed
Mark parameter in ext/zip as sensitive
- ZipArchive::setPassword: $password - ZipArchive::setEncryptionName: $password - ZipArchive::setEncryptionIndex: $password
1 parent 1a5944f commit 7e09d1c

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

ext/zip/php_zip.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include "ext/standard/php_string.h"
2727
#include "ext/pcre/php_pcre.h"
2828
#include "ext/standard/php_filestat.h"
29+
#include "zend_attributes.h"
2930
#include "zend_interfaces.h"
3031
#include "php_zip.h"
3132
#include "php_zip_arginfo.h"
@@ -3255,6 +3256,12 @@ static PHP_MINIT_FUNCTION(zip)
32553256
le_zip_dir = zend_register_list_destructors_ex(php_zip_free_dir, NULL, le_zip_dir_name, module_number);
32563257
le_zip_entry = zend_register_list_destructors_ex(php_zip_free_entry, NULL, le_zip_entry_name, module_number);
32573258

3259+
zend_mark_function_parameter_as_sensitive(&zip_class_entry->function_table, "setpassword", 0 /* $password */);
3260+
#ifdef HAVE_ENCRYPTION
3261+
zend_mark_function_parameter_as_sensitive(&zip_class_entry->function_table, "setencryptionname", 2 /* $password */);
3262+
zend_mark_function_parameter_as_sensitive(&zip_class_entry->function_table, "setencryptionindex", 2 /* $password */);
3263+
#endif
3264+
32583265
return SUCCESS;
32593266
}
32603267
/* }}} */

0 commit comments

Comments
 (0)