Reduced the number of times it is judged whether to compare as absolute values.

Author: SakiTakamachi

ext/bcmath/libbcmath/src/compare.c

@@ -42,34 +42,32 @@
 int _bc_do_compare(bc_num n1, bc_num n2, bool use_sign, bool ignore_last)
 {
 	char *n1ptr, *n2ptr;
+	int result_n1_is_large = -1;
 
 	/* First, compare signs. */
-	if (use_sign && n1->n_sign != n2->n_sign) {
+	if (use_sign) {
 		if (n1->n_sign == PLUS) {
-			/* Positive N1 > Negative N2 */
-			return (1);
+			if (n1->n_sign != n2->n_sign) {
+				return 1;
+			}
+			result_n1_is_large = 1;
 		} else {
-			/* Negative N1 < Positive N1 */
-			return (-1);
+			if (n1->n_sign != n2->n_sign) {
+				return -1;
+			}
 		}
+	} else {
+		result_n1_is_large = 1;
 	}
 
 	/* Now compare the magnitude. */
 	if (n1->n_len != n2->n_len) {
 		if (n1->n_len > n2->n_len) {
 			/* Magnitude of n1 > n2. */
-			if (!use_sign || n1->n_sign == PLUS) {
-				return (1);
-			} else {
-				return (-1);
-			}
+			return result_n1_is_large;
 		} else {
 			/* Magnitude of n1 < n2. */
-			if (!use_sign || n1->n_sign == PLUS) {
-				return (-1);
-			} else {
-				return (1);
-			}
+			return -result_n1_is_large;
 		}
 	}
 
@@ -91,18 +89,10 @@ int _bc_do_compare(bc_num n1, bc_num n2, bool use_sign, bool ignore_last)
 	if (count != 0) {
 		if (*n1ptr > *n2ptr) {
 			/* Magnitude of n1 > n2. */
-			if (!use_sign || n1->n_sign == PLUS) {
-				return (1);
-			} else {
-				return (-1);
-			}
+			return result_n1_is_large;
 		} else {
 			/* Magnitude of n1 < n2. */
-			if (!use_sign || n1->n_sign == PLUS) {
-				return (-1);
-			} else {
-				return (1);
-			}
+			return -result_n1_is_large;
 		}
 	}
 
@@ -112,22 +102,14 @@ int _bc_do_compare(bc_num n1, bc_num n2, bool use_sign, bool ignore_last)
 			for (count = n1->n_scale - n2->n_scale; count > 0; count--) {
 				if (*n1ptr++ != 0) {
 					/* Magnitude of n1 > n2. */
-					if (!use_sign || n1->n_sign == PLUS) {
-						return (1);
-					} else {
-						return (-1);
-					}
+					return result_n1_is_large;
 				}
 			}
 		} else {
 			for (count = n2->n_scale - n1->n_scale; count > 0; count--) {
 				if (*n2ptr++ != 0) {
 					/* Magnitude of n1 < n2. */
-					if (!use_sign || n1->n_sign == PLUS) {
-						return (-1);
-					} else {
-						return (1);
-					}
+					return -result_n1_is_large;
 				}
 			}
 		}