Add debug assertion on type narrowing

nikic · nikic · commit 8e58828e89d3 · 2022-04-10T10:45:52.000+02:00
This ensures that this will show up as a fuzzing failure.
diff --git a/Zend/Optimizer/zend_inference.c b/Zend/Optimizer/zend_inference.c
@@ -1862,6 +1862,9 @@ static void emit_type_narrowing_warning(const zend_op_array *op_array, zend_ssa
 	zend_error_at(
 		E_WARNING, op_array->filename, lineno,
 		"Narrowing occurred during type inference of %s. Please file a bug report on https://github.com/php/php-src/issues", def_op_name);
+#if ZEND_DEBUG
+	ZEND_ASSERT(0 && "Narrowing during type inference");
+#endif
 }
 
 ZEND_API uint32_t ZEND_FASTCALL zend_array_type_info(const zval *zv)

Original file line number	Diff line number	Diff line change
`@@ -1862,6 +1862,9 @@ static void emit_type_narrowing_warning(const zend_op_array *op_array, zend_ssa`
`1862`	`1862`	`zend_error_at(`
`1863`	`1863`	`E_WARNING, op_array->filename, lineno,`
`1864`	`1864`	`"Narrowing occurred during type inference of %s. Please file a bug report on https://github.com/php/php-src/issues", def_op_name);`
	`1865`	`+#if ZEND_DEBUG`
	`1866`	`+ ZEND_ASSERT(0 && "Narrowing during type inference");`
	`1867`	`+#endif`
`1865`	`1868`	`}`
`1866`	`1869`
`1867`	`1870`	`ZEND_API uint32_t ZEND_FASTCALL zend_array_type_info(const zval *zv)`