ValueError if lengths is less than 0

Girgias · Girgias · commit 90dc920ed46f · 2021-03-22T07:09:19.000Z
diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
@@ -2562,7 +2562,7 @@ PHP_FUNCTION(pg_lo_close)
 PHP_FUNCTION(pg_lo_read)
 {
 	zval *pgsql_id;
-	zend_long len;
+	zend_long len = 0;
 	size_t buf_len = PGSQL_LO_READ_BUF_SIZE;
 	int nbytes;
 	zend_string *buf;
@@ -2576,8 +2576,9 @@ PHP_FUNCTION(pg_lo_read)
 		RETURN_THROWS();
 	}
 
-	if (ZEND_NUM_ARGS() > 1) {
-		buf_len = len < 0 ? 0 : len;
+	if (len < 0) {
+		zend_argument_value_error(2, "must be greater or equal than 0");
+		RETURN_THROWS();
 	}
 
 	buf = zend_string_alloc(buf_len, 0);

Original file line number	Diff line number	Diff line change
`@@ -2562,7 +2562,7 @@ PHP_FUNCTION(pg_lo_close)`
`2562`	`2562`	`PHP_FUNCTION(pg_lo_read)`
`2563`	`2563`	`{`
`2564`	`2564`	`zval *pgsql_id;`
`2565`		`- zend_long len;`
	`2565`	`+ zend_long len = 0;`
`2566`	`2566`	`size_t buf_len = PGSQL_LO_READ_BUF_SIZE;`
`2567`	`2567`	`int nbytes;`
`2568`	`2568`	`zend_string *buf;`
`@@ -2576,8 +2576,9 @@ PHP_FUNCTION(pg_lo_read)`
`2576`	`2576`	`RETURN_THROWS();`
`2577`	`2577`	`}`
`2578`	`2578`
`2579`		`- if (ZEND_NUM_ARGS() > 1) {`
`2580`		`- buf_len = len < 0 ? 0 : len;`
	`2579`	`+ if (len < 0) {`
	`2580`	`+ zend_argument_value_error(2, "must be greater or equal than 0");`
	`2581`	`+ RETURN_THROWS();`
`2581`	`2582`	`}`
`2582`	`2583`
`2583`	`2584`	`buf = zend_string_alloc(buf_len, 0);`