Short tag deprecation V2

Author: Girgias

Zend/zend.c

@@ -523,6 +523,7 @@ static void zend_set_default_compile_time_values(void) /* {{{ */
 {
 	/* default compile-time values */
 	CG(short_tags) = short_tags_default;
+	CG(short_tags_notice) = 0;
 	CG(compiler_options) = compiler_options_default;
 }
 /* }}} */

Zend/zend_globals.h

@@ -84,6 +84,7 @@ struct _zend_compiler_globals {
 	zend_bool parse_error;
 	zend_bool in_compilation;
 	zend_bool short_tags;
+	zend_bool short_tags_notice;
 
 	zend_bool unclean_shutdown;
 

Zend/zend_language_scanner.l

@@ -2032,6 +2032,10 @@ string:
 
 <INITIAL>"<?" {
 	if (CG(short_tags)) {
+		if (CG(short_tags_notice) == 0) {
+			zend_error(E_DEPRECATED, "PHP short tags are deprecated. This message will not be printed for further short tags uses. First usage");
+			CG(short_tags_notice) = 1;
+		}
 		BEGIN(ST_IN_SCRIPTING);
 		if (PARSER_MODE()) {
 			SKIP_TOKEN(T_OPEN_TAG);

tests/lang/short_tags.001.phpt

@@ -7,6 +7,7 @@ short_open_tag=on
 echo "Used a short tag\n";
 ?>
 Finished
---EXPECT--
+--EXPECTF--
+Deprecated: PHP short tags are deprecated. This message will not be printed for further short tags uses. First usage in %s on line %d
 Used a short tag
 Finished

tests/lang/short_tags_unique_deprecation_notice.phpt

@@ -0,0 +1,25 @@
+--TEST--
+Unique PHP short tag deprecation with multiple short tags used
+--FILE--
+<?php
+ echo "Used a normal tag\n";
+?>
+<?
+ echo "Used a short tag\n";
+?>
+Non PHP content
+<?php
+ echo "Another normal tag\n";
+?>
+<?
+ echo "Another short tag\n";
+?>
+Finished
+--EXPECTF--
+Deprecated: PHP short tags are deprecated. This message will not be printed for further short tags uses. First usage in %s on line 4
+Used a normal tag
+Used a short tag
+Non PHP content
+Another normal tag
+Another short tag
+Finished