Fixed commit method when setting attributes

SakiTakamachi · SakiTakamachi · commit 98dc072a3f51 · 2023-11-13T03:40:22.000+09:00
diff --git a/ext/pdo_firebird/firebird_driver.c b/ext/pdo_firebird/firebird_driver.c
@@ -884,7 +884,7 @@ static bool firebird_handle_set_attribute(pdo_dbh_t *dbh, zend_long attr, zval *
 						}
 					} else {
 						/* close the transaction */
-						if (H->tr && !firebird_handle_commit(dbh)) {
+						if (H->tr && isc_commit_transaction(H->isc_status, &H->tr)) {
 							return false;
 						}
 						H->in_manually_txn = 0;

Original file line number	Diff line number	Diff line change
`@@ -884,7 +884,7 @@ static bool firebird_handle_set_attribute(pdo_dbh_t dbh, zend_long attr, zval `
`884`	`884`	`}`
`885`	`885`	`} else {`
`886`	`886`	`/* close the transaction */`
`887`		`- if (H->tr && !firebird_handle_commit(dbh)) {`
	`887`	`+ if (H->tr && isc_commit_transaction(H->isc_status, &H->tr)) {`
`888`	`888`	`return false;`
`889`	`889`	`}`
`890`	`890`	`H->in_manually_txn = 0;`