random: Clean up the implementation of Randomizer::getFloat()

Author: TimWolla

ext/random/randomizer.c

@@ -130,13 +130,9 @@ PHP_METHOD(Random_Randomizer, nextFloat)
 }
 /* }}} */
 
-/* {{{ Generates a random float within [min, max).
+/* {{{ Generates a random float within a configurable interval.
  *
- * The algorithm used is the γ-section algorithm as published in:
- *
- * Drawing Random Floating-Point Numbers from an Interval. Frédéric
- * Goualard, ACM Trans. Model. Comput. Simul., 32:3, 2022.
- * https://doi.org/10.1145/3503512
+ * This method uses the γ-section algorithm by Frédéric Goualard.
  */
 PHP_METHOD(Random_Randomizer, getFloat)
 {
@@ -169,32 +165,30 @@ PHP_METHOD(Random_Randomizer, getFloat)
 		}
 
 		RETURN_DOUBLE(php_random_gammasection_closed_open(randomizer->algo, randomizer->status, min, max));
-	}
-	if (zend_string_equals_literal(bounds_name, "ClosedClosed")) {
+	} else if (zend_string_equals_literal(bounds_name, "ClosedClosed")) {
 		if (UNEXPECTED(max < min)) {
 			zend_argument_value_error(2, "must be greater than or equal to argument #1 ($min)");
 			RETURN_THROWS();
 		}
 
 		RETURN_DOUBLE(php_random_gammasection_closed_closed(randomizer->algo, randomizer->status, min, max));
-	}
-	if (zend_string_equals_literal(bounds_name, "OpenClosed")) {
+	} else if (zend_string_equals_literal(bounds_name, "OpenClosed")) {
 		if (UNEXPECTED(max <= min)) {
 			zend_argument_value_error(2, "must be greater than argument #1 ($min)");
 			RETURN_THROWS();
 		}
 
 		RETURN_DOUBLE(php_random_gammasection_open_closed(randomizer->algo, randomizer->status, min, max));
-	}
-	if (zend_string_equals_literal(bounds_name, "OpenOpen")) {
+	} else if (zend_string_equals_literal(bounds_name, "OpenOpen")) {
 		if (UNEXPECTED(max <= min)) {
 			zend_argument_value_error(2, "must be greater than argument #1 ($min)");
 			RETURN_THROWS();
 		}
 
 		RETURN_DOUBLE(php_random_gammasection_open_open(randomizer->algo, randomizer->status, min, max));
+	} else {
+		ZEND_UNREACHABLE();
 	}
-	ZEND_UNREACHABLE();
 }
 /* }}} */