Skip to content

Commit a55b0ab

Browse files
camporternikic
authored andcommitted
oci8: Fix two tests that fail with stricter internal checks
Closes GH-5230
1 parent aa9a3ff commit a55b0ab

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

ext/oci8/tests/array_bind_009.phpt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ oci_bind_array_by_name() and invalid values 9
88
require __DIR__.'/connect.inc';
99

1010
var_dump(oci_bind_array_by_name($c, ":c1", $array, 5, 5, SQLT_CHR));
11-
12-
echo "Done\n";
1311
?>
1412
--EXPECTF--
15-
Warning: oci_bind_array_by_name(): supplied resource is not a valid oci8 statement resource in %s on line %d
16-
bool(false)
17-
Done
13+
Fatal error: Uncaught TypeError: oci_bind_array_by_name(): supplied resource is not a valid oci8 statement resource in %s:%d
14+
Stack trace:
15+
#0 %s: oci_bind_array_by_name(%s)
16+
#1 {main}
17+
thrown in %s on line %d

ext/oci8/tests/array_bind_013.phpt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@ $statement = oci_parse($c, 'SELECT user FROM v$session');
1111

1212
$array = array();
1313

14-
var_dump(oci_bind_array_by_name($statement, ":c1", $array, 5, -10, SQLT_CHR, -10));
14+
try {
15+
var_dump(oci_bind_array_by_name($statement, ":c1", $array, 5, -10, SQLT_CHR, -10));
16+
} catch (ArgumentCountError $exception) {
17+
echo $exception->getMessage() . "\n";
18+
}
19+
1520
var_dump(oci_bind_array_by_name($statement, ":c1", $array, 5, -10));
1621
var_dump(oci_bind_array_by_name($statement, ":c1", $array, 5, -1));
1722
var_dump(oci_bind_array_by_name($statement, ":c1", $array, 5, 0));
@@ -23,8 +28,7 @@ var_dump($array);
2328
echo "Done\n";
2429
?>
2530
--EXPECTF--
26-
Warning: oci_bind_array_by_name() expects at most 6 parameters, 7 given in %s on line %d
27-
NULL
31+
oci_bind_array_by_name() expects at most 6 parameters, 7 given
2832

2933
Warning: oci_bind_array_by_name(): You must provide max length value for empty arrays in %s on line %d
3034
bool(false)

0 commit comments

Comments
 (0)