Review comments

Author: kamil-tekiela

ext/session/session.c

@@ -836,7 +836,7 @@ static PHP_INI_MH(OnUpdateRefererCheck)
 {
 	SESSION_CHECK_ACTIVE_STATE;
 	SESSION_CHECK_OUTPUT_STATE;
-	if (strcmp("", ZSTR_VAL(new_value)) != 0) {
+	if (ZSTR_LEN(new_value) != 0) {
 		php_error_docref(NULL, E_DEPRECATED, "Usage of session.referer_check INI setting is deprecated");
 	}
 	return OnUpdateString(entry, new_value, mh_arg1, mh_arg2, mh_arg3, stage);

ext/session/tests/deprecations.phpt

@@ -61,4 +61,4 @@ Deprecated: session_start(): Disabling session.use_only_cookies INI setting is d
 Deprecated: session_start(): Enabling session.use_trans_sid INI setting is deprecated in %s on line 32
 
 Deprecated: Constant SID is deprecated in %s on line 34
-PHPSESSID=%s
+PHPSESSID=%s

ext/standard/url_scanner_ex.re

@@ -102,7 +102,7 @@ static zend_result php_ini_on_update_tags(zend_ini_entry *entry, zend_string *ne
 
 static PHP_INI_MH(OnUpdateSessionTags)
 {
-	if (strcmp("a=href,area=href,frame=src,form=", ZSTR_VAL(new_value)) != 0) {
+	if (!zend_string_starts_with_literal(new_value, "a=href,area=href,frame=src,form=")) {
 		php_error_docref(NULL, E_DEPRECATED, "Usage of session.trans_sid_tags INI setting is deprecated");
 	}
 	return php_ini_on_update_tags(entry, new_value, mh_arg1, mh_arg2, mh_arg3, stage, /* is_session */ true);
@@ -155,7 +155,7 @@ static zend_result php_ini_on_update_hosts(zend_ini_entry *entry, zend_string *n
 
 static PHP_INI_MH(OnUpdateSessionHosts)
 {
-	if (strcmp("", ZSTR_VAL(new_value)) != 0) {
+	if (ZSTR_LEN(new_value) != 0) {
 		php_error_docref(NULL, E_DEPRECATED, "Usage of session.trans_sid_hosts INI setting is deprecated");
 	}
 	return php_ini_on_update_hosts(entry, new_value, mh_arg1, mh_arg2, mh_arg3, stage, /* is_session */ true);