Skip to content

Commit a7d6c89

Browse files
committed
Add some potential improvements as TODO for GDBM
1 parent 4c37b74 commit a7d6c89

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

ext/dba/dba_gdbm.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ DBA_OPEN_FUNC(gdbm)
4646
if(gmode == -1)
4747
return FAILURE; /* not possible */
4848

49-
dbf = gdbm_open(info->path, 0, gmode, filemode, NULL);
49+
/* TODO Use map_size parameter of dba_open() for block_size? */
50+
/* TODO Add support for other GDBM flags support? See: https://www.gnu.org.ua/software/gdbm/manual/Open.html */
51+
dbf = gdbm_open(info->path, /* int block_size */ 0, gmode, filemode, NULL);
5052

5153
if(dbf) {
5254
info->dbf = pemalloc(sizeof(dba_gdbm_data), info->flags&DBA_PERSISTENT);

0 commit comments

Comments
 (0)