Skip to content

Commit ac62eee

Browse files
authored
Remove DOM_NO_ARGS() and DOM_NOT_IMPLEMENTED() (#12147)
DOM_NO_ARGS() has no users. DOM_NOT_IMPLEMENTED() has a single user.
1 parent 8f8f31a commit ac62eee

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

UPGRADING.INTERNALS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ PHP 8.4 INTERNALS UPGRADE NOTES
2525
a. ext/dom
2626
- dom_read_t and dom_write_t now expect the function to return zend_result
2727
instead of int.
28+
- The macros DOM_NO_ARGS() and DOM_NOT_IMPLEMENTED() have been removed.
2829

2930
========================
3031
4. OpCode changes

ext/dom/domimplementation.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,8 @@ PHP_METHOD(DOMImplementation, getFeature)
227227
RETURN_THROWS();
228228
}
229229

230-
DOM_NOT_IMPLEMENTED();
230+
zend_throw_error(NULL, "Not yet implemented");
231+
RETURN_THROWS();
231232
}
232233
/* }}} end dom_domimplementation_get_feature */
233234

ext/dom/php_dom.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -188,15 +188,6 @@ int php_dom_get_nodelist_length(dom_object *obj);
188188
__ptr = (__prtype)((php_libxml_node_ptr *)__intern->ptr)->node; \
189189
}
190190

191-
#define DOM_NO_ARGS() \
192-
if (zend_parse_parameters_none() == FAILURE) { \
193-
RETURN_THROWS(); \
194-
}
195-
196-
#define DOM_NOT_IMPLEMENTED() \
197-
zend_throw_error(NULL, "Not yet implemented"); \
198-
RETURN_THROWS();
199-
200191
#define DOM_NODELIST 0
201192
#define DOM_NAMEDNODEMAP 1
202193

0 commit comments

Comments
 (0)