Code review

Author: kocsismate

ext/spl/spl_array.stub.php

@@ -96,28 +96,28 @@ class ArrayIterator implements SeekableIterator, ArrayAccess, Serializable, Coun
     public function __construct(array|object $array = [], int $flags = 0) {}
 
     /**
-     * @param array|string|float|int|bool|null $index
+     * @param string|int $index
      * @return bool
      * @alias ArrayObject::offsetExists
      */
     public function offsetExists($index) {}
 
     /**
-     * @param array|string|float|int|bool|null $index
+     * @param string|int $index
      * @return mixed
      * @alias ArrayObject::offsetGet
      */
     public function offsetGet($index) {}
 
     /**
-     * @param array|string|float|int|bool|null $index
+     * @param string|int $index
      * @return void
      * @alias ArrayObject::offsetSet
      */
     public function offsetSet($index, mixed $value) {}
 
     /**
-     * @param array|string|float|int|bool|null $index
+     * @param string|int $index
      * @return void
      * @alias ArrayObject::offsetUnset
      */

ext/spl/spl_array_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 93e4c96c631badd30f847fb24636cb881563a949 */
+ * Stub hash: bedd13338707177e28a021722df64be2f74a7945 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_ArrayObject___construct, 0, 0, 0)
 	ZEND_ARG_TYPE_MASK(0, input, MAY_BE_ARRAY|MAY_BE_OBJECT, "[]")

ext/spl/spl_dllist.c

@@ -758,8 +758,7 @@ PHP_METHOD(SplDoublyLinkedList, offsetGet)
 		RETURN_THROWS();
 	}
 
-	zval *value = &element->data;
-	ZVAL_COPY_DEREF(return_value, value);
+	ZVAL_COPY_DEREF(return_value, &element->data);
 } /* }}} */
 
 /* {{{ Sets the value at the specified $index to $newval. */
@@ -770,10 +769,9 @@ PHP_METHOD(SplDoublyLinkedList, offsetSet)
 	zval *value;
 	spl_dllist_object *intern;
 
-	ZEND_PARSE_PARAMETERS_START(2, 2)
-		Z_PARAM_LONG_OR_NULL(index, index_is_null)
-		Z_PARAM_ZVAL(value)
-	ZEND_PARSE_PARAMETERS_END();
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "l!z", &index, &index_is_null, &value) == FAILURE) {
+		RETURN_THROWS();
+	}
 
 	intern = Z_SPLDLLIST_P(ZEND_THIS);
 
@@ -1066,9 +1064,7 @@ PHP_METHOD(SplDoublyLinkedList, current)
 	if (element == NULL || Z_ISUNDEF(element->data)) {
 		RETURN_NULL();
 	} else {
-		zval *value = &element->data;
-
-		ZVAL_COPY_DEREF(return_value, value);
+		ZVAL_COPY_DEREF(return_value, &element->data);
 	}
 }
 /* }}} */

ext/spl/spl_fixedarray.stub.php

@@ -24,8 +24,11 @@ public function getSize() {}
     /** @return bool */
     public function setSize(int $size) {}
 
-    /** @return bool */
-    public function offsetExists(mixed $index) {}
+    /**
+     * @param int $index
+     * @return bool
+     */
+    public function offsetExists($index) {}
 
     /**
      * @param int $index

ext/spl/spl_fixedarray_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 90b8a23bd4968039522f0b8a6c2034a3784fe78a */
+ * Stub hash: 4b6c37c54416ee46f610baba2a8b2be45d1db96f */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_SplFixedArray___construct, 0, 0, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, size, IS_LONG, 0, "0")
@@ -24,19 +24,17 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_class_SplFixedArray_setSize, 0, 0, 1)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_SplFixedArray_offsetExists, 0, 0, 1)
-	ZEND_ARG_TYPE_INFO(0, index, IS_MIXED, 0)
-ZEND_END_ARG_INFO()
-
-ZEND_BEGIN_ARG_INFO_EX(arginfo_class_SplFixedArray_offsetGet, 0, 0, 1)
 	ZEND_ARG_INFO(0, index)
 ZEND_END_ARG_INFO()
 
+#define arginfo_class_SplFixedArray_offsetGet arginfo_class_SplFixedArray_offsetExists
+
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_SplFixedArray_offsetSet, 0, 0, 2)
 	ZEND_ARG_INFO(0, index)
 	ZEND_ARG_TYPE_INFO(0, value, IS_MIXED, 0)
 ZEND_END_ARG_INFO()
 
-#define arginfo_class_SplFixedArray_offsetUnset arginfo_class_SplFixedArray_offsetGet
+#define arginfo_class_SplFixedArray_offsetUnset arginfo_class_SplFixedArray_offsetExists
 
 #define arginfo_class_SplFixedArray_rewind arginfo_class_SplFixedArray___wakeup