changes from feedback

Author: devnexen

ext/calendar/jewish.c

@@ -439,8 +439,12 @@ static void MoladOfMetonicCycle(
 	r1 = NEW_MOON_OF_CREATION;
 	chk = (zend_long)metonicCycle;
 
-	if (chk > ((ZEND_LONG_MAX / (HALAKIM_PER_METONIC_CYCLE & 0xFFFF)) - NEW_MOON_OF_CREATION) ||
-	    chk > (((ZEND_LONG_MAX / ((HALAKIM_PER_METONIC_CYCLE >> 16) & 0xFFFF))) - (NEW_MOON_OF_CREATION >> 16))) {
+	if ((NEW_MOON_OF_CREATION + chk * (HALAKIM_PER_METONIC_CYCLE & 0xFFFF) > ZEND_LONG_MAX ||
+	    chk * (HALAKIM_PER_METONIC_CYCLE & 0xFFFF) > ZEND_LONG_MAX - NEW_MOON_OF_CREATION ||
+	    chk > (ZEND_LONG_MAX - NEW_MOON_OF_CREATION) / (HALAKIM_PER_METONIC_CYCLE & 0xFFFF)) ||
+	   (((NEW_MOON_OF_CREATION + chk * ((HALAKIM_PER_METONIC_CYCLE >> 16) & 0xFFFF) >> 16) > ZEND_LONG_MAX ||
+	    (chk * ((HALAKIM_PER_METONIC_CYCLE >> 16) & 0xFFFF) >> 16) > ZEND_LONG_MAX - NEW_MOON_OF_CREATION ||
+	    (chk >> 16) > (ZEND_LONG_MAX - NEW_MOON_OF_CREATION) / ((HALAKIM_PER_METONIC_CYCLE >> 16) & 0xFFFF)))) {
 		*pMoladDay = 0;
 		*pMoladHalakim = 0;
 		return;