Update constants and check abstract classes

Author: nikic

ext/tokenizer/tests/PhpToken_extension_errors.phpt

@@ -0,0 +1,28 @@
+--TEST--
+PhpToken extensions that throw during construction
+--FILE--
+<?php
+
+class MyPhpToken1 extends PhpToken {
+    public $extra = UNKNOWN;
+}
+
+try {
+    var_dump(MyPhpToken1::getAll("<?php foo"));
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+
+abstract class MyPhpToken2 extends PhpToken {
+}
+
+try {
+    var_dump(MyPhpToken2::getAll("<?php foo"));
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+Undefined constant 'UNKNOWN'
+Cannot instantiate abstract class MyPhpToken2

ext/tokenizer/tokenizer.c

@@ -116,6 +116,16 @@ PHP_METHOD(PhpToken, getAll)
 	ZEND_PARSE_PARAMETERS_END();
 
 	token_class = zend_get_called_scope(execute_data);
+
+	/* Check construction preconditions in advance, so these are not repeated for each token. */
+	if (token_class->ce_flags & ZEND_ACC_EXPLICIT_ABSTRACT_CLASS) {
+		zend_throw_error(NULL, "Cannot instantiate abstract class %s", ZSTR_VAL(token_class->name));
+		RETURN_THROWS();
+	}
+	if (zend_update_class_constants(token_class) == FAILURE) {
+		RETURN_THROWS();
+	}
+
 	if (!tokenize_common(return_value, source, flags, token_class)) {
 		RETURN_THROWS();
 	}