Skip to content

Commit bfd88e9

Browse files
committed
fixup! Unify structure for ext/random's randomizer tests
1 parent 95561c7 commit bfd88e9

File tree

2 files changed

+9
-19
lines changed

2 files changed

+9
-19
lines changed

ext/random/tests/03_randomizer/next_int.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--TEST--
2-
Random: Randomizer: nextInt(): Basic functionality.
2+
Random: Randomizer: nextInt(): Basic functionality
33
--FILE--
44
<?php
55

ext/random/tests/03_randomizer/pick_array_keys_error.phpt

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--TEST--
2-
Random: Randomizer: pickArrayKeys(): Parameters are correctly validated.
2+
Random: Randomizer: pickArrayKeys(): Parameters are correctly validated
33
--FILE--
44
<?php
55

@@ -10,6 +10,12 @@ function randomizer(): Randomizer
1010
return new Randomizer();
1111
}
1212

13+
try {
14+
var_dump(randomizer()->pickArrayKeys("foo", 2));
15+
} catch (TypeError $e) {
16+
echo $e->getMessage(), PHP_EOL;
17+
}
18+
1319
try {
1420
var_dump(randomizer()->pickArrayKeys([], 0));
1521
} catch (ValueError $e) {
@@ -34,26 +40,10 @@ try {
3440
echo $e->getMessage(), PHP_EOL;
3541
}
3642

37-
var_dump(randomizer()->pickArrayKeys(range(1, 3), 3));
38-
var_dump(randomizer()->pickArrayKeys(range(1, 3), 2));
39-
4043
?>
4144
--EXPECTF--
45+
Random\Randomizer::pickArrayKeys(): Argument #1 ($array) must be of type array, string given
4246
Random\Randomizer::pickArrayKeys(): Argument #1 ($array) cannot be empty
4347
Random\Randomizer::pickArrayKeys(): Argument #2 ($num) must be between 1 and the number of elements in argument #1 ($array)
4448
Random\Randomizer::pickArrayKeys(): Argument #2 ($num) must be between 1 and the number of elements in argument #1 ($array)
4549
Random\Randomizer::pickArrayKeys(): Argument #2 ($num) must be between 1 and the number of elements in argument #1 ($array)
46-
array(3) {
47-
[0]=>
48-
int(%d)
49-
[1]=>
50-
int(%d)
51-
[2]=>
52-
int(%d)
53-
}
54-
array(2) {
55-
[0]=>
56-
int(%d)
57-
[1]=>
58-
int(%d)
59-
}

0 commit comments

Comments
 (0)