Skip to content

Commit c2ca9cd

Browse files
committed
Don't unnecessarily skip mb related tests
Apparently, these tests have been overlooked when we switched to using the `--EXTENSIONS--` section. That caused to skip these tests on AppVeyor. Closes GH-8504.
1 parent c9787b4 commit c2ca9cd

File tree

7 files changed

+19
-6
lines changed

7 files changed

+19
-6
lines changed

ext/exif/tests/exif004.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
--TEST--
22
Check for exif_read_data, Unicode WinXP tags
33
--EXTENSIONS--
4+
mbstring
45
exif
56
--SKIPIF--
67
<?php

ext/standard/tests/file/windows_mb_path/bug54028.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
--TEST--
22
Bug #54028 Directory::read() cannot handle non-unicode chars properly
3+
--EXTENSIONS--
4+
mbstring
35
--SKIPIF--
46
<?php
57
include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";
68

79
skip_if_not_win();
810
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
9-
skip_if_no_required_exts("mbstring");
11+
skip_if_no_required_exts();
1012

1113
?>
1214
--FILE--

ext/standard/tests/file/windows_mb_path/test_cp1251_zend_multibyte_0.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
Test fopen() for reading CP1251 with zend.multibyte
3+
--EXTENSIONS--
4+
mbstring
35
--INI--
46
zend.multibyte=1
57
zend.script_encoding=cp1251
@@ -9,7 +11,7 @@ include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";
911

1012
skip_if_not_win();
1113
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
12-
skip_if_no_required_exts("mbstring");
14+
skip_if_no_required_exts();
1315

1416
?>
1517
--CONFLICTS--

ext/standard/tests/file/windows_mb_path/test_cp1251_zend_multibyte_1.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
Test mkdir/rmdir CP1251 with zend.multibyte
3+
--EXTENSIONS--
4+
mbstring
35
--INI--
46
zend.multibyte=1
57
zend.script_encoding=cp1251
@@ -9,7 +11,7 @@ include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";
911

1012
skip_if_not_win();
1113
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
12-
skip_if_no_required_exts("mbstring");
14+
skip_if_no_required_exts();
1315

1416
?>
1517
--CONFLICTS--

ext/standard/tests/file/windows_mb_path/test_cp1251_zend_multibyte_2.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
Test fopen() for write CP1251 with zend.multibyte
3+
--EXTENSIONS--
4+
mbstring
35
--INI--
46
zend.multibyte=1
57
zend.script_encoding=cp1251
@@ -9,7 +11,7 @@ include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";
911

1012
skip_if_not_win();
1113
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
12-
skip_if_no_required_exts("mbstring");
14+
skip_if_no_required_exts();
1315

1416
?>
1517
--CONFLICTS--

ext/standard/tests/file/windows_mb_path/test_long_path_0.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
--TEST--
22
Basic long path test
3+
--EXTENSIONS--
4+
mbstring
35
--SKIPIF--
46
<?php
57
include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";
68

79
skip_if_not_win();
810
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
9-
skip_if_no_required_exts("mbstring");
11+
skip_if_no_required_exts();
1012

1113
?>
1214
--FILE--

ext/standard/tests/file/windows_mb_path/test_long_path_2.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
--TEST--
22
Basic long path test with file I/O, multibyte path and realpath() check
3+
--EXTENSIONS--
4+
mbstring
35
--SKIPIF--
46
<?php
57
include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";
68

79
skip_if_not_win();
810
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
9-
skip_if_no_required_exts("mbstring");
11+
skip_if_no_required_exts();
1012

1113
?>
1214
--FILE--

0 commit comments

Comments
 (0)