Do not const evaluate ++/-- in SCCP

Yes, now there are memory leaks and bugs but this is too much black magic for me

Author: Girgias

Zend/Optimizer/sccp.c

@@ -664,9 +664,15 @@ static inline zend_result ct_eval_assign_obj(zval *result, zval *value, const zv
 }
 
 static inline zend_result ct_eval_incdec(zval *result, uint8_t opcode, zval *op1) {
+	/* As of PHP 8.3 with the warning/deprecation notices any type other than int/double/null will emit a diagnostic
 	if (Z_TYPE_P(op1) == IS_ARRAY || IS_PARTIAL_ARRAY(op1)) {
 		return FAILURE;
 	}
+	*/
+	/* Decrement on null emits a deprecation notice */
+	if (Z_TYPE_P(op1) != IS_LONG && Z_TYPE_P(op1) != IS_DOUBLE /* && Z_TYPE_P(op1) != IS_NULL */) {
+		return FAILURE;
+	}
 
 	ZVAL_COPY(result, op1);
 	if (opcode == ZEND_PRE_INC
@@ -2109,7 +2115,7 @@ static int try_remove_definition(sccp_ctx *ctx, int var_num, zend_ssa_var *var,
 							break;
 						default:
 							break;
-					}	
+					}
 				}
 				/* we cannot remove instruction that defines other variables */
 				return 0;

ext/opcache/tests/jit/inc_017.phpt

@@ -17,6 +17,6 @@ function foo() {
 }
 var_dump(foo());
 ?>
---EXPECT--
-Warning: Increment on type bool has no effect, this will change in the next major version of PHP in Unknown on line 0
+--EXPECTF--
+Warning: Increment on type bool has no effect, this will change in the next major version of PHP in %sinc_017.php on line 4
 bool(true)

ext/opcache/tests/jit/inc_018.phpt

@@ -17,6 +17,6 @@ function foo() {
 }
 var_dump(foo());
 ?>
---EXPECT--
-Warning: Increment on type bool has no effect, this will change in the next major version of PHP in Unknown on line 0
+--EXPECTF--
+Warning: Increment on type bool has no effect, this will change in the next major version of PHP in %sinc_018.php on line 4
 bool(false)

ext/opcache/tests/opt/inference_016.phpt

@@ -13,12 +13,13 @@ function test() {
     }
 }
 try {
-    @test();
+    test();
 } catch (Throwable $e) {
 	echo $e->getMessage(), "\n";
 }
 ?>
---EXPECT--
-Warning: Decrement on type null has no effect, this will change in the next major version of PHP in Unknown on line 0
+--EXPECTF--
 NULL
+
+Warning: Decrement on type null has no effect, this will change in the next major version of PHP in %sinference_016.php on line %d
 Modulo by zero

ext/opcache/tests/opt/inference_019.phpt

@@ -19,7 +19,6 @@ test();
 ?>
 DONE
 --EXPECTF--
-Warning: Decrement on type null has no effect, this will change in the next major version of PHP in Unknown on line 0
 
-Warning: Decrement on type null has no effect, this will change in the next major version of PHP in %s on line %d
+Warning: Decrement on type null has no effect, this will change in the next major version of PHP in %sinference_019.php on line %d
 DONE

ext/opcache/tests/opt/sccp_035.phpt

@@ -13,6 +13,6 @@ function test() {
 }
 ?>
 DONE
---EXPECT--
-Deprecated: Decrement on empty string is deprecated as non-numeric in Unknown on line 0
+--EXPECTF--
+Deprecated: Decrement on empty string is deprecated as non-numeric in %ssccp_035.php on line 5
 DONE

ext/opcache/tests/opt/sccp_038.phpt

@@ -14,6 +14,6 @@ function foo() {
 foo();
 ?>
 DONE
---EXPECT--
-Deprecated: Increment on non-alphanumeric string is deprecated in Unknown on line 0
+--EXPECTF--
+Deprecated: Increment on non-alphanumeric string is deprecated in %ssccp_038.php on line 5
 DONE