Skip to content

Commit c774a8d

Browse files
authored
Add bison -Wall flag to Windows build (#13098)
Following the d7d3a1c, this adds bison flag -Wall also to Windows build system. Flag has been added via 2127a37.
1 parent ad92501 commit c774a8d

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

ext/json/Makefile.frag.w32

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ ext\json\json_scanner.c ext\json\php_json_scanner_defs.h: ext\json\json_scanner.
22
$(RE2C) $(RE2C_FLAGS) -t ext/json/php_json_scanner_defs.h --no-generation-date -bci -o ext/json/json_scanner.c ext/json/json_scanner.re
33

44
ext\json\json_parser.tab.c ext\json\json_parser.tab.h: ext\json\json_parser.y
5-
$(BISON) --defines -l ext/json/json_parser.y -o ext/json/json_parser.tab.c
5+
$(BISON) $(BISON_FLAGS) --defines -l ext/json/json_parser.y -o ext/json/json_parser.tab.c

win32/build/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,15 @@ $(BUILD_DIR)\$(PHPDLL).def: $(PHP_DLL_DEF_SOURCES)
7878
type $(PHP_DLL_DEF_SOURCES) > $(BUILD_DIR)\$(PHPDLL).def
7979

8080
Zend\zend_ini_parser.c Zend\zend_ini_parser.h: Zend\zend_ini_parser.y
81-
$(BISON) --output=Zend/zend_ini_parser.c -v -d Zend/zend_ini_parser.y
81+
$(BISON) $(BISON_FLAGS) --output=Zend/zend_ini_parser.c -v -d Zend/zend_ini_parser.y
8282

8383
Zend\zend_language_parser.c Zend\zend_language_parser.h: Zend\zend_language_parser.y
84-
$(BISON) --output=Zend/zend_language_parser.c -v -d Zend/zend_language_parser.y
84+
$(BISON) $(BISON_FLAGS) --output=Zend/zend_language_parser.c -v -d Zend/zend_language_parser.y
8585
@if "$(SED)" neq "" $(SED) -i "s,^int zendparse\(.*\),ZEND_API int zendparse\1,g" Zend/zend_language_parser.c
8686
@if "$(SED)" neq "" $(SED) -i "s,^int zendparse\(.*\),ZEND_API int zendparse\1,g" Zend/zend_language_parser.h
8787

8888
sapi\phpdbg\phpdbg_parser.c sapi\phpdbg\phpdbg_parser.h: sapi\phpdbg\phpdbg_parser.y
89-
$(BISON) --output=sapi/phpdbg/phpdbg_parser.c -v -d sapi/phpdbg/phpdbg_parser.y
89+
$(BISON) $(BISON_FLAGS) --output=sapi/phpdbg/phpdbg_parser.c -v -d sapi/phpdbg/phpdbg_parser.y
9090

9191
!if $(RE2C) != ""
9292
Zend\zend_ini_scanner.c Zend\zend_ini_scanner_defs.h: Zend\zend_ini_scanner.l

win32/build/confutils.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2978,6 +2978,7 @@ function toolset_setup_project_tools()
29782978
PATH_PROG('lib', null, 'MAKE_LIB');
29792979

29802980
var BISON = PATH_PROG('bison');
2981+
DEFINE('BISON_FLAGS', '-Wall');
29812982
if (BISON) {
29822983
var BISONVERS = probe_binary(BISON, "longversion");
29832984
STDOUT.WriteLine(' Detected bison version ' + BISONVERS);

0 commit comments

Comments
 (0)