Skip to content

Commit d3abcae

Browse files
ext/snmp: use memcpy() instead of memmove() (#10498)
memcpy() may be faster because it does not have to consider overlapping buffers.
1 parent c2d4baf commit d3abcae

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ext/snmp/snmp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ static void php_snmp_internal(INTERNAL_FUNCTION_PARAMETERS, int st,
397397
php_snmp_error(getThis(), PHP_SNMP_ERRNO_NOERROR, "");
398398

399399
if (st & SNMP_CMD_WALK) { /* remember root OID */
400-
memmove((char *)root, (char *)(objid_query->vars[0].name), (objid_query->vars[0].name_length) * sizeof(oid));
400+
memcpy((char *)root, (char *)(objid_query->vars[0].name), (objid_query->vars[0].name_length) * sizeof(oid));
401401
rootlen = objid_query->vars[0].name_length;
402402
objid_query->offset = objid_query->count;
403403
}
@@ -551,7 +551,7 @@ static void php_snmp_internal(INTERNAL_FUNCTION_PARAMETERS, int st,
551551
php_snmp_error(getThis(), PHP_SNMP_ERRNO_OID_NOT_INCREASING, "Error: OID not increasing: %s", buf2);
552552
keepwalking = false;
553553
} else {
554-
memmove((char *)(objid_query->vars[0].name), (char *)vars->name, vars->name_length * sizeof(oid));
554+
memcpy((char *)(objid_query->vars[0].name), (char *)vars->name, vars->name_length * sizeof(oid));
555555
objid_query->vars[0].name_length = vars->name_length;
556556
keepwalking = true;
557557
}

0 commit comments

Comments
 (0)