Add tests for DatePeriod properties

Author: duncan3dc

ext/date/php_date.c

@@ -2148,8 +2148,6 @@ static void date_register_classes(void) /* {{{ */
 	date_object_handlers_period.get_properties = date_object_get_properties_period;
 	date_object_handlers_period.get_property_ptr_ptr = NULL;
 	date_object_handlers_period.get_gc = date_object_get_gc_period;
-	date_object_handlers_period.read_property = date_period_read_property;
-	date_object_handlers_period.write_property = date_period_write_property;
 
 #define REGISTER_PERIOD_CLASS_CONST_STRING(const_name, value) \
 	zend_declare_class_constant_long(date_ce_period, const_name, sizeof(const_name)-1, value);
@@ -5255,34 +5253,6 @@ PHP_METHOD(DatePeriod, __wakeup)
 }
 /* }}} */
 
-/* {{{ date_period_read_property */
-static zval *date_period_read_property(zval *object, zval *member, int type, void **cache_slot, zval *rv)
-{
-	zval *zv;
-	if (type != BP_VAR_IS && type != BP_VAR_R) {
-		zend_throw_error(NULL, "Retrieval of DatePeriod properties for modification is unsupported");
-		return &EG(uninitialized_zval);
-	}
-
-	Z_OBJPROP_P(object); /* build properties hash table */
-
-	zv = std_object_handlers.read_property(object, member, type, cache_slot, rv);
-	if (Z_TYPE_P(zv) == IS_OBJECT && Z_OBJ_HANDLER_P(zv, clone_obj)) {
-		/* defensive copy */
-		ZVAL_OBJ(zv, Z_OBJ_HANDLER_P(zv, clone_obj)(zv));
-	}
-
-	return zv;
-}
-/* }}} */
-
-/* {{{ date_period_write_property */
-static void date_period_write_property(zval *object, zval *member, zval *value, void **cache_slot)
-{
-	zend_throw_error(NULL, "Writing to DatePeriod properties is unsupported");
-}
-/* }}} */
-
 /*
  * Local variables:
  * tab-width: 4

ext/date/tests/DatePeriod_properties.phpt

@@ -0,0 +1,18 @@
+--TEST--
+DatePeriod: Test properties
+--INI--
+date.timezone=UTC
+--FILE--
+<?php
+$interval = new DateInterval('P1D');
+$period = new class(new DateTime, $interval, new DateTime) extends DatePeriod {
+    public $extra = "stuff";
+};
+
+var_dump($period->extra);
+$period->extra = "modified";
+var_dump($period->extra);
+?>
+--EXPECT--
+string(5) "stuff"
+string(8) "modified"