MFH: Bugfix# 39435: 'foo' instanceof bar gives invalid opcode error

sgolemon · sgolemon · commit db87e11e6b1e · 2006-12-12T23:25:23.000Z
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
@@ -3627,6 +3627,10 @@ void zend_do_instanceof(znode *result, znode *expr, znode *class_znode, int type
 		}
 	}
 
+	if (expr->op_type == IS_CONST) {
+		zend_error(E_COMPILE_ERROR, "instanceof expects an object instance, constant given");
+	}
+
 	opline = get_next_op(CG(active_op_array) TSRMLS_CC);
 	opline->opcode = ZEND_INSTANCEOF;
 	opline->result.op_type = IS_TMP_VAR;

Original file line number	Diff line number	Diff line change
`@@ -3627,6 +3627,10 @@ void zend_do_instanceof(znode result, znode expr, znode *class_znode, int type`
`3627`	`3627`	`}`
`3628`	`3628`	`}`
`3629`	`3629`
	`3630`	`+ if (expr->op_type == IS_CONST) {`
	`3631`	`+ zend_error(E_COMPILE_ERROR, "instanceof expects an object instance, constant given");`
	`3632`	`+ }`
	`3633`	`+`
`3630`	`3634`	`opline = get_next_op(CG(active_op_array) TSRMLS_CC);`
`3631`	`3635`	`opline->opcode = ZEND_INSTANCEOF;`
`3632`	`3636`	`opline->result.op_type = IS_TMP_VAR;`