Skip to content

Commit e319247

Browse files
remicolletremicollet
committed
Skip readline tests which fail with libedit
Add specific libedit test (output slightly differs)
1 parent 31d67bd commit e319247

8 files changed

+131
-4
lines changed

‎ext/readline/tests/libedit_callback_handler_install_001.phpt

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
--TEST--
2+
readline_callback_handler_install(): Basic test
3+
--SKIPIF--
4+
<?php if (!extension_loaded("readline") || !function_exists('readline_callback_handler_install')) die("skip");
5+
if (READLINE_LIB != "libedit") die("skip libedit only");
6+
?>
7+
--FILE--
8+
<?php
9+
10+
function foo() {
11+
readline_callback_handler_remove();
12+
}
13+
14+
var_dump(readline_callback_handler_install('testing: ', 'foo'));
15+
var_dump(readline_callback_handler_install('testing: ', 'foobar!'));
16+
var_dump(readline_callback_handler_install('testing: '));
17+
18+
?>
19+
--EXPECTF--
20+
bool(true)
21+
22+
Warning: readline_callback_handler_install(): foobar! is not callable in %s on line %d
23+
bool(false)
24+
25+
Warning: readline_callback_handler_install() expects exactly 2 parameters, 1 given in %s on line %d
26+
NULL

‎ext/readline/tests/libedit_callback_handler_remove_001.phpt

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
--TEST--
2+
readline_callback_handler_remove(): Basic test
3+
--SKIPIF--
4+
<?php if (!extension_loaded("readline") || !function_exists('readline_callback_handler_remove')) die("skip");
5+
if (READLINE_LIB != "libedit") die("skip libedit only");
6+
?>
7+
--FILE--
8+
<?php
9+
10+
var_dump(readline_callback_handler_remove());
11+
var_dump(readline_callback_handler_install('testing: ', 'foo'));
12+
13+
function foo() { }
14+
var_dump(readline_callback_handler_install('testing: ', 'foo'));
15+
var_dump(readline_callback_handler_remove());
16+
17+
?>
18+
--EXPECTF--
19+
bool(false)
20+
bool(true)
21+
bool(true)
22+
bool(true)

‎ext/readline/tests/libedit_info_001.phpt

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
--TEST--
2+
readline_info(): Basic test
3+
--SKIPIF--
4+
<?php if (!extension_loaded("readline")) die("skip"); ?>
5+
if (READLINE_LIB != "libedit") die("skip libedit only");
6+
--FILE--
7+
<?php
8+
9+
var_dump(readline_info());
10+
var_dump(readline_info(1));
11+
var_dump(readline_info(1,1));
12+
var_dump(readline_info('line_buffer'));
13+
var_dump(readline_info('readline_name'));
14+
var_dump(readline_info('readline_name', 1));
15+
var_dump(readline_info('readline_name'));
16+
var_dump(readline_info('attempted_completion_over',1));
17+
var_dump(readline_info('attempted_completion_over'));
18+
19+
?>
20+
--EXPECTF--
21+
array(6) {
22+
["line_buffer"]=>
23+
string(0) ""
24+
["point"]=>
25+
int(0)
26+
["end"]=>
27+
int(0)
28+
["library_version"]=>
29+
string(%d) "%s"
30+
["readline_name"]=>
31+
string(0) ""
32+
["attempted_completion_over"]=>
33+
int(0)
34+
}
35+
NULL
36+
NULL
37+
string(0) ""
38+
string(0) ""
39+
string(0) ""
40+
string(1) "1"
41+
int(0)
42+
int(1)

‎ext/readline/tests/libedit_write_history_001.phpt

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
--TEST--
2+
readline_write_history(): Basic test
3+
--SKIPIF--
4+
<?php if (!extension_loaded("readline") || !function_exists('readline_add_history')) die("skip");
5+
if (READLINE_LIB != "libedit") die("skip libedit only");
6+
?>
7+
--FILE--
8+
<?php
9+
10+
$name = tempnam('/tmp', 'readline.tmp');
11+
12+
readline_add_history('foo');
13+
readline_add_history('');
14+
readline_add_history(1);
15+
readline_add_history(NULL);
16+
readline_write_history($name);
17+
18+
var_dump(file_get_contents($name));
19+
20+
unlink($name);
21+
22+
?>
23+
--EXPECT--
24+
string(21) "_HiStOrY_V2_
25+
foo
26+
27+
1
28+
29+
"

‎ext/readline/tests/readline_callback_handler_install_001.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
--TEST--
22
readline_callback_handler_install(): Basic test
33
--SKIPIF--
4-
<?php if (!extension_loaded("readline") || !function_exists('readline_callback_handler_install')) die("skip"); ?>
4+
<?php if (!extension_loaded("readline") || !function_exists('readline_callback_handler_install')) die("skip");
5+
if (READLINE_LIB == "libedit") die("skip readline only");
6+
?>
57
--FILE--
68
<?php
79

‎ext/readline/tests/readline_callback_handler_remove_001.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
--TEST--
22
readline_callback_handler_remove(): Basic test
33
--SKIPIF--
4-
<?php if (!extension_loaded("readline") || !function_exists('readline_callback_handler_remove')) die("skip"); ?>
4+
<?php if (!extension_loaded("readline") || !function_exists('readline_callback_handler_remove')) die("skip");
5+
if (READLINE_LIB == "libedit") die("skip readline only");
6+
?>
57
--FILE--
68
<?php
79

‎ext/readline/tests/readline_info_001.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
--TEST--
22
readline_info(): Basic test
33
--SKIPIF--
4-
<?php if (!extension_loaded("readline")) die("skip"); ?>
4+
<?php if (!extension_loaded("readline")) die("skip");
5+
if (READLINE_LIB == "libedit") die("skip readline only");
6+
?>
57
--FILE--
68
<?php
79

‎ext/readline/tests/readline_write_history_001.phpt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
--TEST--
22
readline_write_history(): Basic test
33
--SKIPIF--
4-
<?php if (!extension_loaded("readline") || !function_exists('readline_add_history')) die("skip"); ?>
4+
<?php if (!extension_loaded("readline") || !function_exists('readline_add_history')) die("skip");
5+
if (READLINE_LIB == "libedit") die("skip readline only");
6+
?>
57
--FILE--
68
<?php
79

0 commit comments

Comments
 (0)