Use assertion for user filters

Girgias · Girgias · commit e477a5d77bfe · 2020-08-06T14:42:40.000+02:00
diff --git a/ext/standard/user_filters.c b/ext/standard/user_filters.c
@@ -298,12 +298,7 @@ static php_stream_filter *user_filter_factory_create(const char *filtername,
 			}
 			efree(wildcard);
 		}
-		if (fdat == NULL) {
-			zend_throw_error(NULL, "Filter \"%s\" is not in the user-filter map, "
-				"but user-filter-factory was invoked for it."
-				"This is a bug, please report it at https://bugs.php.net", filtername);
-			return NULL;
-		}
+		ZEND_ASSERT(fdat);
 	}
 
 	/* bind the classname to the actual class */

Original file line number	Diff line number	Diff line change
`@@ -298,12 +298,7 @@ static php_stream_filter user_filter_factory_create(const char filtername,`
`298`	`298`	`}`
`299`	`299`	`efree(wildcard);`
`300`	`300`	`}`
`301`		`- if (fdat == NULL) {`
`302`		`- zend_throw_error(NULL, "Filter \"%s\" is not in the user-filter map, "`
`303`		`- "but user-filter-factory was invoked for it."`
`304`		`- "This is a bug, please report it at https://bugs.php.net", filtername);`
`305`		`- return NULL;`
`306`		`- }`
	`301`	`+ ZEND_ASSERT(fdat);`
`307`	`302`	`}`
`308`	`303`
`309`	`304`	`/* bind the classname to the actual class */`