stream_bucket_new() cannot return false

php_stream_bucket_new() is infallible.

Author: nikic

ext/opcache/Optimizer/zend_func_info.c

@@ -409,7 +409,7 @@ static const func_info_t func_infos[] = {
 	F1("str_rot13",                    MAY_BE_STRING),
 	F1("stream_get_filters",           MAY_BE_ARRAY | MAY_BE_ARRAY_KEY_LONG | MAY_BE_ARRAY_OF_STRING),
 	F1("stream_bucket_make_writeable", MAY_BE_NULL | MAY_BE_OBJECT),
-	F1("stream_bucket_new",            MAY_BE_FALSE | MAY_BE_OBJECT),
+	F1("stream_bucket_new",            MAY_BE_OBJECT),
 	F1("sys_get_temp_dir",             MAY_BE_STRING),
 
 	/* ext/date */

ext/standard/basic_functions.stub.php

@@ -1445,6 +1445,8 @@ function rawurldecode(string $string): string {}
 /** @param resource $context */
 function get_headers(string $url, int $format = 0, $context = null): array|false {}
 
+/* user_filters.c */
+
 /** @param resource $brigade */
 function stream_bucket_make_writeable($brigade): ?object {}
 
@@ -1455,7 +1457,7 @@ function stream_bucket_prepend($brigade, object $bucket): void {}
 function stream_bucket_append($brigade, object $bucket): void {}
 
 /** @param resource $stream */
-function stream_bucket_new($stream, string $buffer): object|false {}
+function stream_bucket_new($stream, string $buffer): object {}
 
 function stream_get_filters(): array {}
 

ext/standard/basic_functions_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: c61d8a28acaa2a7206f74287dce98282f2fedd2a */
+ * Stub hash: 621176b0f79f4fcb833c6be568adb2070239cce1 */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_set_time_limit, 0, 1, _IS_BOOL, 0)
 	ZEND_ARG_TYPE_INFO(0, seconds, IS_LONG, 0)
@@ -2146,7 +2146,7 @@ ZEND_END_ARG_INFO()
 
 #define arginfo_stream_bucket_append arginfo_stream_bucket_prepend
 
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_stream_bucket_new, 0, 2, MAY_BE_OBJECT|MAY_BE_FALSE)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_stream_bucket_new, 0, 2, IS_OBJECT, 0)
 	ZEND_ARG_INFO(0, stream)
 	ZEND_ARG_TYPE_INFO(0, buffer, IS_STRING, 0)
 ZEND_END_ARG_INFO()

ext/standard/user_filters.c

@@ -500,10 +500,6 @@ PHP_FUNCTION(stream_bucket_new)
 
 	bucket = php_stream_bucket_new(stream, pbuffer, buffer_len, 1, php_stream_is_persistent(stream));
 
-	if (bucket == NULL) {
-		RETURN_FALSE;
-	}
-
 	ZVAL_RES(&zbucket, zend_register_resource(bucket, le_bucket));
 	object_init(return_value);
 	add_property_zval(return_value, "bucket", &zbucket);