Allow creating ReflectionGenerator after termination

Author: TimWolla

ext/reflection/php_reflection.c

@@ -2251,7 +2251,6 @@ ZEND_METHOD(ReflectionGenerator, __construct)
 {
 	zval *generator, *object;
 	reflection_object *intern;
-	zend_execute_data *ex;
 
 	object = ZEND_THIS;
 	intern = Z_REFLECTION_P(object);
@@ -2260,12 +2259,6 @@ ZEND_METHOD(ReflectionGenerator, __construct)
 		RETURN_THROWS();
 	}
 
-	ex = ((zend_generator *) Z_OBJ_P(generator))->execute_data;
-	if (!ex) {
-		_DO_THROW("Cannot create ReflectionGenerator based on a terminated Generator");
-		RETURN_THROWS();
-	}
-
 	if (intern->ce) {
 		zval_ptr_dtor(&intern->obj);
 	}

ext/reflection/tests/ReflectionGenerator_after_termination.phpt

@@ -0,0 +1,33 @@
+--TEST--
+Creating ReflectionGenerator is legal after termination.
+--FILE--
+<?php
+
+function foo() {
+    yield;
+}
+
+$gens = [
+    (new class() {
+        function a() {
+            yield from foo();
+        }
+    })->a(),
+    (function() {
+        yield;
+    })(),
+    foo(),
+];
+
+foreach ($gens as $gen) {
+    foreach ($gen as $dummy);
+
+    $ref = new ReflectionGenerator($gen);
+    echo $ref->getFunction()->getName(), PHP_EOL;
+}
+
+?>
+--EXPECTF--
+a
+{closure:%s:%d}
+foo