Skip to content

Commit f494a36

Browse files
committed
Remove bogus skipifs in get_browser tests
We provide this file, it should be readable. These checks no longer work, since --INI-- values are no longer passed to --SKIPIF--.
1 parent a3e454a commit f494a36

File tree

5 files changed

+0
-44
lines changed

5 files changed

+0
-44
lines changed

ext/standard/tests/misc/bug65550.phpt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@
22
Bug #65550 (get_browser() incorrectly parses entries with "+" sign)
33
--INI--
44
browscap={PWD}/browscap.ini
5-
--SKIPIF--
6-
<?php
7-
if (!is_readable(ini_get('browscap'))) die('skip browscap.ini file ' . ini_get('browscap') . ' not readable');
8-
?>
95
--FILE--
106
<?php
117
$user_agent = 'Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US) AppleWebKit/522+ (KHTML, like Gecko, Safari/522) OmniWeb/v613';

ext/standard/tests/misc/get_browser_basic.phpt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@
22
Test get_browser() function : basic functionality
33
--INI--
44
browscap={PWD}/browscap.ini
5-
--SKIPIF--
6-
<?php
7-
/**
8-
* Basic test, it would be pretty much coincidence if there's
9-
* a browscap.ini on another place that isn't valid.
10-
*/
11-
if(! is_readable( ini_get( 'browscap' ) ) ) {
12-
die( 'skip: browscap.ini file ' . ini_get('browscap') . " not readable" );
13-
}
14-
?>
155
--FILE--
166
<?php
177
/* Prototype : mixed get_browser([string browser_name [, bool return_array]])

ext/standard/tests/misc/get_browser_error.phpt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@
22
Test get_browser() function : error functionality
33
--INI--
44
browscap={PWD}/browscap.ini
5-
--SKIPIF--
6-
<?php
7-
/**
8-
* Basic test, it would be pretty much coincidence if there's
9-
* a browscap.ini on another place that isn't valid.
10-
*/
11-
if(! is_readable( ini_get( 'browscap' ) ) ) {
12-
die( 'skip: browscap.ini file ' . ini_get('browscap') . " not readable" );
13-
}
14-
?>
155
--FILE--
166
<?php
177
/* Prototype : mixed get_browser([string browser_name [, bool return_array]])

ext/standard/tests/misc/get_browser_variation1.phpt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@
22
Test get_browser() function : variation functionality: extra browser names
33
--INI--
44
browscap={PWD}/browscap.ini
5-
--SKIPIF--
6-
<?php
7-
/**
8-
* Basic test, it would be pretty much coincidence if there's
9-
* a browscap.ini on another place that isn't valid.
10-
*/
11-
if(! is_readable( ini_get( 'browscap' ) ) ) {
12-
die( 'skip: browscap.ini file ' . ini_get('browscap') . " not readable" );
13-
}
14-
?>
155
--FILE--
166
<?php
177
/* Prototype : mixed get_browser([string browser_name [, bool return_array]])

ext/standard/tests/misc/get_browser_variation2.phpt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,6 @@
22
Test get_browser() function variation : Return data as object
33
--INI--
44
browscap={PWD}/browscap.ini
5-
--SKIPIF--
6-
<?php
7-
/**
8-
* Basic test, it would be pretty much coincidence if there's
9-
* a browscap.ini on another place that isn't valid.
10-
*/
11-
if(! is_readable( ini_get( 'browscap' ) ) ) {
12-
die( 'skip: browscap.ini file ' . ini_get('browscap') . " not readable" );
13-
}
14-
?>
155
--FILE--
166
<?php
177

0 commit comments

Comments
 (0)